unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: Alan Third <alan@idiocy.org>, 15667@debbugs.gnu.org
Subject: bug#15667: 24.3.50; ns-win.el -- keymap assignments for isearch-repeat-backward/forward.
Date: Wed, 20 Jan 2021 03:42:50 +0100	[thread overview]
Message-ID: <87a6t45nx1.fsf@gnus.org> (raw)
In-Reply-To: <m2k3h7jxtx.wl%esq@lawlist.com> (Keith David Bershatsky's message of "Sun, 20 Oct 2013 17:02:02 -0700")

Keith David Bershatsky <esq@lawlist.com> writes:

> The global-map key assignments within ns-win.el for
> isearch-repeat-backward and isearch-repeat-forward are insufficient to
> achieve the behavior contemplated by the source code of isearch.el.
> Specifically, the isearch-mode terminates immediately after invoking
> the repeat functions and the sticky highlight of searches found does
> not automatically cleanup.  Invoking these repeat functions should
> keep isearch-mode active, and then sticky highlight should
> automatically clean up when exiting the isearch (e.g., by pressing the
> return key after the search).  The problem is corrected by the
> following keymap assignments, which mirrors the usage within the
> source code of isearch.el
>
> (define-key global-map [?\s-f] 'isearch-forward)
> (define-key esc-map [?\s-f] 'isearch-forward-regexp)
> (define-key minibuffer-local-isearch-map [?\s-f] 'isearch-forward-exit-minibuffer)
> (define-key isearch-mode-map [?\s-f] 'isearch-repeat-forward)
>
> (define-key global-map [?\s-F] 'isearch-backward)
> (define-key esc-map [?\s-F] 'isearch-backward-regexp)
> (define-key minibuffer-local-isearch-map [?\s-F] 'isearch-reverse-exit-minibuffer)
> (define-key isearch-mode-map [?\s-F] 'isearch-repeat-backward)

(I'm going through old bug reports that unfortunately got no response at
the time.)

I don't really use the Emacs on Macos much, but perhaps Alan has an
opinion here?  Added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-01-20  2:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21  0:02 bug#15667: 24.3.50; ns-win.el -- keymap assignments for isearch-repeat-backward/forward Keith David Bershatsky
2021-01-20  2:42 ` Lars Ingebrigtsen [this message]
2021-01-21 21:47   ` Alan Third
2021-01-22 18:19     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6t45nx1.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=15667@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).