From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14257: 24.3.50; (elisp) `Modifying Menus' - clarify second example Date: Wed, 20 Jan 2021 04:19:14 +0100 Message-ID: <87a6t447nx.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 14257@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 20 04:20:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l242W-00098O-Jr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 04:20:12 +0100 Original-Received: from localhost ([::1]:33740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l242V-0004cV-MM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 22:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l242M-0004cE-Nw for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 22:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l242M-0006RJ-FH for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 22:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l242M-0003uv-9U for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 22:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2021 03:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14257 X-GNU-PR-Package: emacs Original-Received: via spool by 14257-submit@debbugs.gnu.org id=B14257.161111276714996 (code B ref 14257); Wed, 20 Jan 2021 03:20:02 +0000 Original-Received: (at 14257) by debbugs.gnu.org; 20 Jan 2021 03:19:27 +0000 Original-Received: from localhost ([127.0.0.1]:52381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l241n-0003to-7G for submit@debbugs.gnu.org; Tue, 19 Jan 2021 22:19:27 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:39652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l241k-0003tV-RO for 14257@debbugs.gnu.org; Tue, 19 Jan 2021 22:19:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TEtmYaHQqRlU2XUnJXQCSIaHfma8LeM4bPchg9/EaUs=; b=Rcd14LGMXnbJeCg0yT4rX3Apdr ieWsAZ7yEfdCP+BRS9mmMVsPeTj4Yu0nhQ65LlLx0Pq0gG2JsbNuy9iai3aIZWGHlGanW6xam/+UT gKXYbowEEiUAWBlwhuM3srtFa0FUwk6JVY0RKht8D8R2ArA9KqHG76XhTe11KOJUrWbI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l241b-0000C1-H8; Wed, 20 Jan 2021 04:19:18 +0100 X-Now-Playing: Sir Steady Arobby & His International Brothers Dance Band Of Nigeria's _Nigeria 70 (No Wahala: Highlife, Afro-Funk & Juju 1973-1987)_: "Onuma Dimnobi" In-Reply-To: (Drew Adams's message of "Wed, 24 Apr 2013 09:21:08 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198235 Archived-At: "Drew Adams" writes: > It might help if some motivation were given for the second example: > > (define-key-after > (lookup-key shell-mode-map [menu-bar signals]) > [work] '("Work" . work-command) 'break) > > My guess is that that example was added to tell users how to deal with > the error that used to be raised if you used something like this: > > (define-key-after minibuffer-local-completion-map > [menu-bar minibuf foo] > '(menu-item "Foo" foo) 'quit) > > Instead of this: > > (define-key-after (lookup-key minibuffer-local-completion-map > [menu-bar minibuf]) > [foo] > '(menu-item "Foo" foo) 'quit) > > That error is no longer raised. I've now altered the second example to be more like the first example in Emacs 28. It's perhaps useful to illustrate the other syntax, too, but the first syntax is to be encouraged, I guess. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no