unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Bastian Beranek <bastian.beischer@gmail.com>
Cc: 46299@debbugs.gnu.org
Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames.
Date: Sun, 07 Feb 2021 21:05:12 +0200	[thread overview]
Message-ID: <87a6sfu0fi.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAK9AuB-J8U8Q4YCLjvmHmcEz06bZP3GxKEToTnWgqxtm8QdFzA@mail.gmail.com> (Bastian Beranek's message of "Sat, 6 Feb 2021 13:16:54 +0100")

> I added code to make the frame setting of tab-bar-lines as well as the
> default-frame-alist value dependent on tab-bar-show to the
> tab-bar-mode function.
> I think with this the part to which sets frame parameters in
> tab-bar-show :set is not needed because (tab-bar-mode 1) is called
> anyway, which already does everything.
>
> What do you think about the attached patch?

I think your earlier idea was better - to have a dynamic function which
counts the numbers of tabs and adapts the number of tab-bar-lines
according to the value of tab-bar-show.

Then such a function could be called from many places:
- tab-bar-mode
- tab-bar-show :set
- from the end of tab-bar-new-tab-to
- from the end of tab-bar-close-tab
- from the end of tab-bar-close-other-tabs

to sync the actual tabs with the value of tab-bar-show.





  reply	other threads:[~2021-02-07 19:05 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 16:14 bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames Bastian Beischer
2021-02-05  8:54 ` Juri Linkov
2021-02-05 10:10   ` Bastian Beranek
2021-02-05 14:11     ` Bastian Beranek
2021-02-06 12:16       ` Bastian Beranek
2021-02-07 19:05         ` Juri Linkov [this message]
2021-02-07 23:03           ` Bastian Beranek
2021-02-08 17:50             ` Bastian Beranek
2021-02-08 18:19               ` Juri Linkov
2021-02-08 19:04                 ` Bastian Beranek
2021-02-09  8:00                   ` martin rudalics
2021-02-09  8:15                     ` Bastian Beranek
2021-02-09  8:58                       ` martin rudalics
2021-02-09  9:23                         ` Bastian Beranek
2021-02-09  9:45                           ` martin rudalics
2021-02-09 11:44                             ` Bastian Beranek
2021-02-09 17:32                               ` martin rudalics
2021-02-09 18:06                               ` Juri Linkov
2021-02-09 18:46                                 ` Bastian Beranek
2021-02-09 19:08                                   ` Eli Zaretskii
2021-02-09 19:01                                 ` Eli Zaretskii
2021-02-10 18:24                               ` Juri Linkov
2021-02-11 12:14                                 ` Bastian Beranek
2021-02-11 17:34                                   ` Bastian Beranek
2021-02-12  9:31                                   ` Juri Linkov
2021-02-12 10:24                                     ` Bastian Beranek
2021-02-12 14:47                                       ` Bastian Beranek
2021-02-12 19:23                                         ` Bastian Beranek
2021-02-13 18:23                                           ` Juri Linkov
2021-02-13 19:02                                             ` Bastian Beranek
2021-02-13 19:46                                               ` Juri Linkov
2021-02-14 18:44                                                 ` Juri Linkov
2021-02-15 10:05                                                   ` Bastian Beranek
2021-02-15 15:26                                                   ` Eli Zaretskii
2021-02-15 15:32                                                     ` Bastian Beranek
2021-02-15 15:53                                                       ` Eli Zaretskii
2021-02-16 10:40                                                         ` Bastian Beranek
2021-02-14 13:08                                             ` Bastian Beranek
2021-02-14 18:50                                               ` Juri Linkov
2021-02-14 19:28                                                 ` Juri Linkov
2021-02-15  8:16                                                 ` martin rudalics
2021-02-15  9:07                                                   ` Juri Linkov
2021-02-15 10:08                                                     ` martin rudalics
2021-02-15 10:12                                                   ` Bastian Beranek
2021-02-15 10:09                                                 ` Bastian Beranek
2021-02-15 17:01                                                   ` Juri Linkov
2021-02-15 22:10                                                     ` Bastian Beranek
2021-02-16  2:08                                                       ` bug#46299: [External] : " Drew Adams
2021-02-16 10:59                                                       ` Bastian Beranek
2021-02-16 15:31                                                         ` Bastian Beranek
2021-02-16 17:28                                                           ` Juri Linkov
2021-02-24 18:46                                                             ` Juri Linkov
2021-02-10 18:20                       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6sfu0fi.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=46299@debbugs.gnu.org \
    --cc=bastian.beischer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).