From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#46761: 28.0.50; Speed up json.el encoding Date: Sat, 27 Feb 2021 19:30:59 +0000 Message-ID: <87a6rp1f64.fsf@tcd.ie> References: <87a6rtszgk.fsf@tcd.ie> <06140794-3f40-8a35-573d-4414d2611afc@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20225"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46761@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 27 20:32:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lG5KM-00059Z-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Feb 2021 20:32:34 +0100 Original-Received: from localhost ([::1]:42728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lG5KL-0006aM-Es for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Feb 2021 14:32:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG5Jq-0006a0-E5 for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 14:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lG5Jq-0000Rg-5K for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 14:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lG5Jq-0005OL-0H for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Feb 2021 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46761-submit@debbugs.gnu.org id=B46761.161445427120670 (code B ref 46761); Sat, 27 Feb 2021 19:32:01 +0000 Original-Received: (at 46761) by debbugs.gnu.org; 27 Feb 2021 19:31:11 +0000 Original-Received: from localhost ([127.0.0.1]:45423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG5J0-0005NK-N1 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 14:31:10 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:45037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG5Iw-0005Mr-VA for 46761@debbugs.gnu.org; Sat, 27 Feb 2021 14:31:08 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id h98so11850612wrh.11 for <46761@debbugs.gnu.org>; Sat, 27 Feb 2021 11:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/ABstaptImsMo6JIJg32Q5I0p/gzMoBRcf8JxwtIquQ=; b=H0NrDTYLZ/lb1fJA1aH8XsZSKjYacekmK3Gf6F+72u1XeoSlw30QyD6FHbnYNES7z9 VChyWt16XkgD85rLHgPgTYoQB79rZEVTAdYf1NU/4nsPruh9oRBivxSTWNxCOJmNHOSy kTEMSkfbmkiXc0/zHEwmABcky4PUOD50chxO6TPb2ZiSEqdzDYPtJC4toS4ZuzjccJE/ 9fi9uz8n+zlrJO4PHmOSb2TwglH6z1PVIfzooGrd2m6zQHDFBT6Ifbb4TJjzTjtCVjq4 S2mkEQ0gUOeZfsnlKDGPGWCnnTRBTbb4++Gkp4Bp9px3OYNFjymy/sBliP9ZepGFhLk8 FPNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/ABstaptImsMo6JIJg32Q5I0p/gzMoBRcf8JxwtIquQ=; b=CbPgiiWXJ43S/w9YKorGXPvaBz/x2SUUKkjhOBPCftxPJqVvFKy7lNyO2pdT6sq/Pa hOJQ/ph6Ibkt66drpOMmdvp0K8DMpe5q8MHTTIlEsIl1jcwg8Is2Exm5Vaq37wl81wai 9HUivAmk5l/flXOQ6ErLYy96xrpLKBFjSc9+IuushsL3ocEzpe5v14XdIS9YKBExomKA NV+aIGS3DHmJ+aJh+3odvoZMekiqxAM0wyeth3c2d0FvBEHOm0RVe9lzJWBV8v+7Vgc0 3ohSN5tzQxIMj5FgO7SjnQAHJIC/QPBHGRygWhVz9vVYaPV+2daID3D4U2zyJLBtI7nz 3hqw== X-Gm-Message-State: AOAM530xwFX5tvy8DlPgGXm4YqKdwaTbb3c7G657ARP2VzEEHf8AEIa3 FhpU+xL2dQ6zmsgin+NfklTdHA== X-Google-Smtp-Source: ABdhPJz9MSHqZ10Xi98FqylHjS7h8RR8S59Fnpq4QIRG4UTLdKTp2XWUpnJf+lZkrxwexFC0hWhWTw== X-Received: by 2002:a5d:66c8:: with SMTP id k8mr9203250wrw.163.1614454261108; Sat, 27 Feb 2021 11:31:01 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id g1sm16353650wmh.9.2021.02.27.11.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Feb 2021 11:31:00 -0800 (PST) In-Reply-To: <06140794-3f40-8a35-573d-4414d2611afc@yandex.ru> (Dmitry Gutov's message of "Sat, 27 Feb 2021 20:51:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200979 Archived-At: Dmitry Gutov writes: > Looking good. Thanks. > I'm guessing there is an approximate size where structures smaller than that > size will get slower to encode because of this change (creating a temp buffer > and switching to it are not entirely free), Of course, e.g. {"a": true}. > but I can't think of a use case where this would matter. Agreed, because by the time a single with-temp-buffer becomes the limiting factor, the encoding time for such small objects is trivially small. -- Basil