From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#46915: [PATCH] Remove unecessary change_req arg from overlays_at() Date: Sat, 06 Mar 2021 16:03:14 -0800 Message-ID: <87a6rfn83h.fsf@mdeb> References: <835z27jagi.fsf@gnu.org> <87r1kuadow.fsf@mdeb> <83r1kuzk6a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17343"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46915@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 01:04:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIgu6-0004Mz-2e for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 01:04:14 +0100 Original-Received: from localhost ([::1]:41962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIgu4-0006i9-Kk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 19:04:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIgtu-0006hw-Oi for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 19:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIgtu-00030s-FV for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 19:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIgtu-0006hD-9G for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 19:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Mar 2021 00:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46915-submit@debbugs.gnu.org id=B46915.161507540725680 (code B ref 46915); Sun, 07 Mar 2021 00:04:02 +0000 Original-Received: (at 46915) by debbugs.gnu.org; 7 Mar 2021 00:03:27 +0000 Original-Received: from localhost ([127.0.0.1]:38543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIgtL-0006g7-3T for submit@debbugs.gnu.org; Sat, 06 Mar 2021 19:03:27 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:36371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIgtI-0006fs-I2 for 46915@debbugs.gnu.org; Sat, 06 Mar 2021 19:03:25 -0500 X-Originating-IP: 24.113.169.116 Original-Received: from mdeb (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 069821C0008; Sun, 7 Mar 2021 00:03:17 +0000 (UTC) In-Reply-To: <83r1kuzk6a.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201701 Archived-At: Eli Zaretskii writes: >> From: Matt Armstrong >> Cc: 46915@debbugs.gnu.org >> Date: Thu, 04 Mar 2021 12:03:59 -0800 >> >> So, the benefit of this change can be summarized: >> >> - We don't think the current overlay implementation is necessarily the >> right thing, so we can presume that this area will change at some >> point. >> >> - If we simplify the API, future changes will be easier to review. In >> particular, nobody will ever have to think about callers that want a >> *PREV_PTR value with a false CHANGE_REQ, and no future implementer >> will feel like they need to provide that functionality. > > I'm okay with doing this nad similar changes as part of landing the > noverlay branch (or as part of some other similar redesign of how > overlays work in Emacs). What I'd like to avoid is installing this > change separately, as if it alone has enough merit. if the goal is to > replace the current implementation with a more efficient one, that's a > good change, and API simplifications could very well come with it. > But not without it and not ahead of it. > > It's a bit like fixing whitespace: we don't like doing it in separate > changesets, but together with other significant changes in the same > area of the code. > > So I urge you to continue the work on the noverlay branch, and if that > branch will come with this and other changes in the internal APIs, > that's fine by me. My problem is only with installing API changes > right now, when we are not at all sure yet the overlays redesign will > indeed land any time soon. > > OK? I'm happy to defer this for now. I might come back and ask that this change go in before doing actual surgery on the overlay implementation. In the past, on other projects, I have found it worthwhile to first simplify APIs, and assert various assumed invariants more rigidly, and let those changes bake for a while, before beginning to modify implementations. But, I would agree that those kinds of changes are best done according to some sort of generally agreed upon plan, not just ad hoc.