From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nicolas Goaziou Newsgroups: gmane.emacs.bugs Subject: bug#48149: 27.2; Wrong underline width when the line char has a width of 2 Date: Sun, 02 May 2021 18:08:50 +0200 Message-ID: <87a6pd86el.fsf__26701.9492619269$1619972220$gmane$org@nicolasgoaziou.fr> References: <87fsz62b1w.wl-shingo.fg8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29735"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: 48149@debbugs.gnu.org To: Shingo Tanaka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 02 18:16:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldEm7-0007e4-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 18:16:55 +0200 Original-Received: from localhost ([::1]:46266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldEm6-0005P7-Nq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 12:16:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldEfT-0006g0-Vl; Sun, 02 May 2021 12:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldEfT-0004XC-Lf; Sun, 02 May 2021 12:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldEfT-0004TR-H2; Sun, 02 May 2021 12:10:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 May 2021 16:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48149 X-GNU-PR-Package: org-mode,emacs Original-Received: via spool by 48149-submit@debbugs.gnu.org id=B48149.161997174517135 (code B ref 48149); Sun, 02 May 2021 16:10:03 +0000 Original-Received: (at 48149) by debbugs.gnu.org; 2 May 2021 16:09:05 +0000 Original-Received: from localhost ([127.0.0.1]:43491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldEeU-0004S6-4h for submit@debbugs.gnu.org; Sun, 02 May 2021 12:09:05 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:46247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldEeQ-0004Rs-Je for 48149@debbugs.gnu.org; Sun, 02 May 2021 12:09:01 -0400 X-Originating-IP: 185.131.40.67 Original-Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 7277F1C0007; Sun, 2 May 2021 16:08:51 +0000 (UTC) In-Reply-To: <87fsz62b1w.wl-shingo.fg8@gmail.com> (Shingo Tanaka's message of "Sun, 02 May 2021 10:12:43 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205436 Archived-At: Hello, Shingo Tanaka writes: > When exporting org-mode document to plain text (either ascii/unicode/utf-= 8) > with `org-export-dispatch', Emacs inserts lines under headlines, inline > tasks, table rows and titles of the document, TOC, list of listings, list= of > tables and footnotes. The problem is it inserts too long (double width) = line > when the line character has a width of 2. > > Those lines are made of 3 types of characters below (in ox-ascii.el): > 1) org-ascii-underline > 2) (if (eq (plist-get info :ascii-charset) 'utf-8) ?=E2=94=80 ?_) > 3) (if utf8p ?=E2=94=81 ?_) > > In case of 1), it correctly takes account of the case in which the charac= ter > has a width of 2 in `org-ascii--build-title', by dividing the line width = by > `(char-width under-char)' (line 700-701), maybe because the character is = user > configurable and its width in unknown. However, in case of 2) and > 3), maybe because the characters is embedded in the code, it looks like o= nly > considering the character always has a width of 1. But the reality is > character ?=E2=94=80 or ?=E2=94=81 can have a width of 2 in the screen di= splayed with some > fonts (ex. "Noto Sans Mono CJK JP"), and in that case the line width gets > doubled of the expected width. > > Attached one is a potential patch. The basic concepts are: > > a) Do the same in case of 2) and 3) as in case of 1) > (dividing the line width by `(char-width under-char)', > assuming `char-width-table' is correctly set) >=20=20=20=20=20 > b) Prefer the longer line width if the width is odd, even in case of 1) > (adding `(1- (char-width under-char))' to dividend, > just because it should be more beautiful ;-) ) Thank you. This looks good. I cannot apply it on "maint" branch, however. Also, a proper commit message would be nice. Could you send an updated patch? Moreover, have you signed FSF papers already? This is above limit for tiny changes. Regards, --=20 Nicolas Goaziou