From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47992: 27; 28; Phase out use of `equal` in `add-hook`, `remove-hook` Date: Mon, 03 May 2021 10:50:18 +0200 Message-ID: <87a6pcdwvp.fsf@gnus.org> References: <87mttdh57n.fsf@gnus.org> <8b715c19-e6bf-90a8-75a2-3ae3e1ace563@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47992@debbugs.gnu.org, monnier@iro.umontreal.ca, jakanakaevangeli@chiru.no To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 11:09:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldUZh-00088i-It for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 11:09:09 +0200 Original-Received: from localhost ([::1]:35528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldUZg-0003XB-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 05:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldUIA-0007oQ-02 for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 04:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldUI9-00083f-Nl for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 04:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldUI9-0007et-Lt for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 04:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 08:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47992 X-GNU-PR-Package: emacs Original-Received: via spool by 47992-submit@debbugs.gnu.org id=B47992.162003183329416 (code B ref 47992); Mon, 03 May 2021 08:51:01 +0000 Original-Received: (at 47992) by debbugs.gnu.org; 3 May 2021 08:50:33 +0000 Original-Received: from localhost ([127.0.0.1]:46190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldUHg-0007eO-Vq for submit@debbugs.gnu.org; Mon, 03 May 2021 04:50:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldUHe-0007eD-4I for 47992@debbugs.gnu.org; Mon, 03 May 2021 04:50:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pglmuWifz2FXN/PyAeu9Jg0TOKtsr2utakJJZGIqC2I=; b=EYMvLus98J2yJz31T2loYZugqd V+upeyQM87axVSbmI5iJTnB0QXBoXgrkML0YOA8wof7U4st0IZoWjAjsM0y0j1C/Q7b6OJ9nSAXtm fFmCxhRlwHOezthDq5Spfh1hoWIFNYKK6tkUvbeu/X/3O7wNuxO/wEEJanBgKKQRYJKk=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldUHS-0002ZY-PV; Mon, 03 May 2021 10:50:21 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX18e6IenU7KCq6 qqP////NhAZvAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFAwgtITJYGwYAAAF1SURBVDjLnZRrloMg DIVD2YAJGzCwgdDsf29zA45infnT9Gg1H3kSJPpCWOoiysyiAwy91op3KLkQveoJtIm6O2V3I6oL 4KoFYOjTAgaDCfQOT3egbPjbwtPiSmrTZuMpfQDVsXbKLXj7A6jRG87JUcfdAu87kXWfIh+AjvQW C1wnuLmq/wFcrfOGarxH/DVGo7Q9LUquuyWT9wN43ayb9Bp1NFkAGpJ2YXkAaVT22kbheoENd9eC taOfi4UBNI+tD/a60rWuljmAyplViXidkmEi5tasLXFKvoUuVr0WgHGiXeoeJbZ0AI8oeEIG6rFv 7zmi1V7TokSmcraEIyR6mC2y6PyxH5hbnW2W+jlwI7nN+QEEHSyWDXs1gYxTAAs0tzg0uU+gA7Sw Mh+L0wUQOqatxWSdoHicgHASwxa36YpxKHCSMn4oPl8xmOdcTgNbY/ipyTdQfkEocdbyAU5PA4T4 BDeDKWkNbvRrmQ+LNz/lm0/PD+2LX9+nW6Z9AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTAz VDA4OjQ1OjMzKzAwOjAwv2JNrwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0wM1QwODo0NToz MyswMDowMM4/9RMAAAAASUVORK5CYII= X-Now-Playing: The Style Council's _The Complete Adventures (1)_: "My Ever Changing Moods [12'' Version]" In-Reply-To: <8b715c19-e6bf-90a8-75a2-3ae3e1ace563@daniel-mendler.de> (Daniel Mendler's message of "Sun, 2 May 2021 12:37:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205487 Archived-At: Daniel Mendler writes: > 1. Do almost nothing, but document the behavior of `add/remove-hook` > more precisely. Add a warning, that the functions should not be used > with large/cyclic closures and an symbol indirection should be used in > such scenarios. Generally it should be recommended to add symbols. I've now added such a recommendation to the add-hook doc string in Emacs 28. > 2. As you propose we could either add new `add/remove-hook-eq` variants. > 3. Add an argument to the `add/remove-hook` functions, which allows to > turn on `eq` equality. Adding another argument to the functions doesn't seem all that attractive... but... neither does adding a new pair of functions, really... I guess the doc change might have to suffice here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no