From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#48302: [PATCH v2] Re: bug#48302: [PATCH] Abbreviate `find' properties in M-x rgrep on MS Windows Date: Tue, 11 May 2021 09:11:01 +0200 Message-ID: <87a6p1hhiy.fsf@gmx.de> References: <83r1ig8kk3.fsf@gnu.org> <87bl9jdog9.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32906"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48302@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 11 09:12:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgMYr-0008On-Uw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 09:12:09 +0200 Original-Received: from localhost ([::1]:60894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgMYq-00060Q-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 03:12:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgMYk-00060E-8c for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 03:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgMYk-0004v3-16 for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 03:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgMYj-00085M-Ri for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 03:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 07:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48302-submit@debbugs.gnu.org id=B48302.162071707231011 (code B ref 48302); Tue, 11 May 2021 07:12:01 +0000 Original-Received: (at 48302) by debbugs.gnu.org; 11 May 2021 07:11:12 +0000 Original-Received: from localhost ([127.0.0.1]:34837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgMXw-000847-0X for submit@debbugs.gnu.org; Tue, 11 May 2021 03:11:12 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:34757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgMXu-00083t-2y for 48302@debbugs.gnu.org; Tue, 11 May 2021 03:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620717063; bh=9KZKRjE2McD4bQr8qt+Aw6UTWx9Ulf7mrPX9WbS3FuA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YPqSvJcTeewnIU5wSw3KCtIuwKtvbILveZK267cPKnEfYhxCApx0fPlKpsxOPEvJb qXebLLjIQbdR6I2Te8UN8hrnCB/zqIQOSMf2PE2o2tEmsGg961JeN/ZT9RifV3OAvz zGLDuz3xy7SAuYUJ0ixBIYtcG55MUfgHiw6jKlzs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.125.0]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXp5a-1m1Igk3WP6-00YCda; Tue, 11 May 2021 09:11:02 +0200 In-Reply-To: (Jim Porter's message of "Mon, 10 May 2021 21:36:25 -0700") X-Provags-ID: V03:K1:e0UfM0eYcZAWRKG1ZxHoSEIri9Rv9Jyhp+QiHjsSN5E8bRLOde/ k+lPrTyzi9r44+qzqZ/ueV75z7Qr8VBgyF9wbWqm6VYJ2y8DZkSPVkMOC8HqvfLO3C8aSXA s2vhFD4RCaoT3GBuoccXMng1FdPg5YpBlQyNz2Rh4/g+rmYsUxfECAEV/tBFdBb7pcgPPC1 vbXLAoSHYtfcQJ8V4oFWw== X-UI-Out-Filterresults: notjunk:1;V03:K0:vEQ83v3Nicg=:aRDB6DXYO96Qn1IgZA8ABp 0DHMYv8Y0VjtP6jRHuYtLskaVrJpoYDymD6eLd00n2ReLgmqmz8L+/wwHFhLN+slJeC+Zno96 A7aRgyz9lkxHjp3DAc9L2kGPCqICywOMtfmNBxJD31Y01kqPnwdamssY8sS60mXrfJbWHcjM3 awNOgAAiidWnRdATfiVyj7lMIO6XTyVH2N1iDJA+1UeMFXXDxl/yjyW773UCVXZketagtHQjI 1KSmXQa7Y9cfyOfdrvyDxzpvqp3bTBbuVJ6+uqCBhYK+c0ZUQUxoQAZt8ACvQmrSgbdLaP3mv i2LannZZyiuiKVqIe6LhYwRjnV2wo/RdLTRVp/1fHxXZabyN3VzgrKYSU11N0VXJA76GEsqLg uCThBcebKLOiiQu8x69Q4zff6bFfopzlGEaj9RBAX/YrKQeaB9tBxkwY8m+m+xodxvzwDvEUJ 5UcIoU2AzSZm325xGBMXK/zTFpF3IgUCYk+xNrbMrxogiiLwBquLK/t7rpKGjlSf1Cyb39HZb C3ysT6uj5ODpV6Lmrk/nov50TZZibEPcrCjeK4hVQ4OzwOdJcXXoSJ64oLnhtxvJDtFoM/y/A Wz/X6Wu34/UL+WWDCl3xMGcjTwaJ18SysCTnyMk7xElCR7fMes5hiXDwIPHwakhaXJiZuBZPY cBykTpBDDtrmSCBfYgrmqevheNmR59nOtt11oauONhculw5lrK710S4/1J+VhruAsjeS/Sb6c 3Yk2hXhaiQVpSnq4Mlolf1i1LOy+Ajit88cVPq+rLGtTAS/gtrozw7cOpTJ8C1C+yiVt7YtD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206204 Archived-At: Jim Porter writes: Hi Jim, > Thanks for the pointers. Attached is an updated patch that tests the 4 > cases you described. Thanks. LGTM. Just one nit: > + (should (equal (grep-tests--get-rgrep-abbreviation) nil)))) This is (should-not (grep-tests--get-rgrep-abbreviation)) Eli, do you have further comments? Otherwise, I would commit it in Jim's name. Best regards, Michael.