* bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs
[not found] ` <20210518143810.4DA8920947@vcs0.savannah.gnu.org>
@ 2021-05-18 14:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-18 15:13 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-05-18 14:48 UTC (permalink / raw)
To: 48492; +Cc: Gong Qijian
> * lisp/startup.el (command-line): Don't bug out on redumping Emacs
> (bug#48492).
[...]
> @@ -1197,11 +1197,11 @@ please check its value")
>
> ;; Re-evaluate predefined variables whose initial value depends on
> ;; the runtime context.
> - (setq custom-delayed-init-variables
> - ;; Initialize them in the same order they were loaded, in case there
> - ;; are dependencies between them.
> - (nreverse custom-delayed-init-variables))
> - (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
> + (when (listp custom-delayed-init-variables)
> + (mapc #'custom-reevaluate-setting
> + ;; Initialize them in the same order they were loaded, in
> + ;; case there are dependencies between them.
> + (reverse custom-delayed-init-variables)))
> (setq custom-delayed-init-variables t)
>
> ;; Warn for invalid user name.
While this is a good short term fix, I think what we would ideally want
instead is that those settings be re-evaluated yet-again when we start
the re-dumped Emacs.
So maybe instead of setting the var to t, we should use another var to
denote that we've already init'd those vars (and re-set that other var
some time when we redump).
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs
2021-05-18 14:48 ` bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-05-18 15:13 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-18 15:13 UTC (permalink / raw)
To: 48492; +Cc: Gong Qijian, Stefan Monnier
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> So maybe instead of setting the var to t, we should use another var to
> denote that we've already init'd those vars (and re-set that other var
> some time when we redump).
Yeah, overloading `custom-delayed-init-variables' with two different
semantics is a bit awkward.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-18 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210518143808.11815.577@vcs0.savannah.gnu.org>
[not found] ` <20210518143810.4DA8920947@vcs0.savannah.gnu.org>
2021-05-18 14:48 ` bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-18 15:13 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).