unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Gustavo Barros <gusbrs.2016@gmail.com>
Cc: 48472@debbugs.gnu.org
Subject: bug#48472: [FR] A small suggestion for repeat-mode
Date: Wed, 19 May 2021 00:04:38 +0300	[thread overview]
Message-ID: <87a6orwy6x.fsf@mail.linkov.net> (raw)
In-Reply-To: <87o8d847ls.fsf@gmail.com> (Gustavo Barros's message of "Tue, 18 May 2021 08:14:08 -0300")

tags 48472 fixed
close 48472 28.0.50
thanks

Hi Gustavo,

>> An "exit function" returned by `set-transient-map' is a clever thing,
>> without such returned function it would be more complicated to implement.
>> I quickly tried it out, and it works indeed.
>
> We have to thank whoever put it there.  And it seems to be there out of
> design and foresight.  As far as my grepping went (not that thorough),
> I didn't find an instance of usage of this return value in Emacs' code base
> as of yet.

It's amazing that the function returns exactly what we need
even though its return value is not yet used anywhere.
So I copied the same design to another similar function
display-buffer-override-next-command to return exitfun as well.

>> A new user option could be named `repeat-exit-timeout'.
>> 
>
> Sounds good to me.  And, I'm not sure I should be reading between the lines
> of your answer, but I could not avoid it, so I'll be forthcoming. I've gone
> as far as I'm allowed to.  I'd be happy to offer a patch, but no papers...

You are welcome to sign papers, so the next time you could offer a patch.
Now I pushed the implementation based on your suggestion, thanks for it!

(The implementation also includes a lot of small details like correctly
handling the messages, etc.)

If you are running on 27.2, you could still take the second part
of repeat.el from Emacs 28.





  reply	other threads:[~2021-05-18 21:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 20:05 bug#48472: [FR] A small suggestion for repeat-mode Gustavo Barros
2021-05-17 21:24 ` Juri Linkov
2021-05-18 11:14   ` Gustavo Barros
2021-05-18 21:04     ` Juri Linkov [this message]
2021-05-18 22:09       ` Gustavo Barros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6orwy6x.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=48472@debbugs.gnu.org \
    --cc=gusbrs.2016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).