bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder

[pillule <pillule@riseup.net>]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]


pillule <pillule@riseup.net> writes:

> Hi, I wished re-builder was in a dedicated window (otherwise killing its buffer let
> you with an unwanted buffer in a narrow window), so I wrote a patch about it.
> It also have the benefit to uses display-buffer and so, to allow user-customization.

This second one is more reliable when it comes to call re-builder from a side
window.
(the original version simply prevented that case since a side window is not
splittable)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Use display-buffer for re-builder --]
[-- Type: text/x-diff, Size: 1695 bytes --]

From a52953ef8ef146cd105ad6dee7882e0dc298512d Mon Sep 17 00:00:00 2001
From: Trust me I am a doctor <pillule@riseup.net>
Date: Thu, 17 Jun 2021 05:56:34 +0200
Subject: [PATCH] Use display-buffer with re-builder

* lisp/emacs-lisp/re-builder.el (re-builder): Uses 'display-buffer'
with 'display-buffer-in-direction' to display the reb-buffer. This
allow user-customizations and using windows usually not splitables.
Add a dedication to its window so killing this buffer actually quit
its window.
---
 lisp/emacs-lisp/re-builder.el | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el
index 7d042a9102..747f741091 100644
--- a/lisp/emacs-lisp/re-builder.el
+++ b/lisp/emacs-lisp/re-builder.el
@@ -355,11 +355,15 @@ re-builder
       (reb-delete-overlays))
     (setq reb-target-buffer (current-buffer)
           reb-target-window (selected-window))
-    (select-window (or (get-buffer-window reb-buffer)
-		       (progn
-			 (setq reb-window-config (current-window-configuration))
-			 (split-window (selected-window) (- (window-height) 4)))))
-    (switch-to-buffer (get-buffer-create reb-buffer))
+    (select-window
+     (or (get-buffer-window reb-buffer)
+         (progn (setq reb-window-config (current-window-configuration))
+                (display-buffer
+                 (get-buffer-create reb-buffer)
+                 `((display-buffer-in-direction)
+                   (direction . ,(if (eq (window-dedicated-p nil) 'side)
+                                     'bottom 'down))
+                   (dedicated . t))))))
     (font-lock-mode 1)
     (reb-initialize-buffer)))
 
-- 
2.20.1


[-- Attachment #3: Type: text/plain, Size: 119 bytes --]


I also tested it against the atomic windows showcased in the manual
and it seems ok, but I am not familiar with them.