From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Wed, 25 Aug 2021 14:04:00 +0200 Message-ID: <87a6l5k9xr.fsf@gnus.org> References: <838s0rvyfu.fsf@gnu.org> <83zgt6vi43.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15733"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50179@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 14:05:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIreZ-0003pO-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 14:05:11 +0200 Original-Received: from localhost ([::1]:42278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIreY-0001lY-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 08:05:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIreR-0001jL-28 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 08:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIreQ-00081w-OV for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 08:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIreQ-0007kv-Iy for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 08:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.162989306329766 (code B ref 50179); Wed, 25 Aug 2021 12:05:02 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 25 Aug 2021 12:04:23 +0000 Original-Received: from localhost ([127.0.0.1]:45991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIrdi-0007jv-Kl for submit@debbugs.gnu.org; Wed, 25 Aug 2021 08:04:23 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIrdb-0007jb-QY for 50179@debbugs.gnu.org; Wed, 25 Aug 2021 08:04:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PdcSUyjgR8AkAl6clYqW5iozbQY0XdQuBd1EPKwZ10I=; b=pOC3Ki8dmrgMYF87CzjO3Bd8gp cd1hi4LIRQqtpzCS1U0k74jNvoT7jxhoNC7G7H0NRUm81YUJIj4QQMrzH4kYBuRKUaz8QACLkLN9u YMqgF/dtlvJJD6KKObV0FyXt6l5dWemFPo/zFDdVH2jZVX//11pde+oRpDf8SeBM3xds=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIrdQ-0003tR-T2; Wed, 25 Aug 2021 14:04:05 +0200 In-Reply-To: (Jim Porter's message of "Tue, 24 Aug 2021 15:53:52 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212614 Archived-At: Jim Porter writes: > Ok, here are updated patches addressing your comments. I fixed the > grammatical error in the comment, improved the commit message for the > second patch, and switched to using `ansi-color-bold-is-bright' in > both files. I left `ansi-bright-color-names-vector' as a defcustom > though, since I think that's the right thing to do there (see my > previous message), but I can change that later if we agree on a > different/better route there. Thanks; applied to Emacs 28. But unfortunately, I didn't notice the test failure until after pushing. :-/ 1 unexpected results: FAILED term-colors-bold-is-bright And the faces are: (font-lock-face ((:foreground "yellow3" :background "unspecified-bg" :inverse-video nil) :inherit term-bold)) (font-lock-face ((:foreground "yellow2" :background "unspecified-bg" :inverse-video nil) :inherit term-bold)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no