From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50226: 27.1; Fix uncomment-region with space-only comment-continue Date: Fri, 27 Aug 2021 16:39:46 +0200 Message-ID: <87a6l3osst.fsf@gnus.org> References: <87r1efc6hb.fsf@poincare.umons.ac.be> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1943"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50226@debbugs.gnu.org To: Christophe Troestler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 16:41:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJd2p-0000JX-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 16:41:23 +0200 Original-Received: from localhost ([::1]:53650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJd2n-0002Vx-6b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 10:41:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJd2U-0002VS-8u for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 10:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJd2U-00020U-0g for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 10:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJd2T-00047m-MP for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 10:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50226 X-GNU-PR-Package: emacs Original-Received: via spool by 50226-submit@debbugs.gnu.org id=B50226.163007521215778 (code B ref 50226); Fri, 27 Aug 2021 14:41:01 +0000 Original-Received: (at 50226) by debbugs.gnu.org; 27 Aug 2021 14:40:12 +0000 Original-Received: from localhost ([127.0.0.1]:52661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJd1b-00046I-HF for submit@debbugs.gnu.org; Fri, 27 Aug 2021 10:40:12 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:32802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJd1V-00045W-4Q for 50226@debbugs.gnu.org; Fri, 27 Aug 2021 10:40:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pntqzdYsueeraYJNXPD0T5PTfv5KJOJ+8yMX524BUQg=; b=Zk0cMqjmCsSa2Qq+P9i7GnH/Cq uR52sNOr5KoDrdvzwehKN/OM3tRPjGWQdSSUxTe6uiqGtntm34niaIWDICIF+RHTnEWlZiuIVlHly ZzK9ir85Gblyt1XA0JFGXxx6O4ILmlsoWcZjhFE8FslkuuxLjkQJocItB3zfxXcv2h3o=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJd1K-00037g-E6; Fri, 27 Aug 2021 16:39:54 +0200 In-Reply-To: <87r1efc6hb.fsf@poincare.umons.ac.be> (Christophe Troestler's message of "Fri, 27 Aug 2021 16:22:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212814 Archived-At: Christophe Troestler writes: > In the Emacs development branch, `comment-region-default-1' has been > fixed to handle the case 'comment-continue' is entirely made of > whitespace (commit 5c93063129). However, `uncomment-region-default-1' > did not receive an appropriate fix as the following test shows: > > (let ((comment-style 'multi-line) > (comment-continue " ") > (text " a\n b")) > (equal text > (with-temp-buffer > (c-mode) > (insert text) > (comment-region (point-min) (point-max)) > (uncomment-region (point-min) (point-max)) > (buffer-string)))) > > The attached patch fixes that. Thanks; applied to Emacs 28 (and I added the test as an ert test case). I forget whether I've asked before: This change (including the three previous ones) was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, we'd need to get copyright assignment on file. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no