From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 27 Aug 2021 21:57:06 +0200 Message-ID: <87a6l2d5kd.fsf@gmx.net> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <87o89ieruy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20987"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Dmitry Gutov , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 21:58:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJhzb-0005BR-Qw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 21:58:23 +0200 Original-Received: from localhost ([::1]:49018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJhzZ-00061i-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 15:58:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJhzG-00061Y-Ph for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 15:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJhzG-0003TX-Fn for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 15:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJhzG-0008HF-6s for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 15:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163009423731766 (code B ref 39452); Fri, 27 Aug 2021 19:58:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 27 Aug 2021 19:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:53083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJhyX-0008GI-J2 for submit@debbugs.gnu.org; Fri, 27 Aug 2021 15:57:17 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:51313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJhyU-0008G3-OI for 39452@debbugs.gnu.org; Fri, 27 Aug 2021 15:57:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630094227; bh=dD8hyRuVSMlbbtTVarXzirSyBgfu5QiK4X1QBPsspCc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Yiql/6yl5ZfZnrmSGksEuRyeK01aR3H39MT9oNcEy1GtIHyza/1lHZzphH4dwpC0v mvKeuDnq/lJZb7ijDq8afMBhE0uVsDb6a5sIIrrE5E7xiOcOyN1b5+Pbo7OUirKgva qinHAAPvZi5hoSzJUzqsKrw6Sq5aNC7OWiAhciJA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs ([178.1.124.4]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3KPg-1n2M9B0Th4-010N8Q; Fri, 27 Aug 2021 21:57:07 +0200 In-Reply-To: <87o89ieruy.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 27 Aug 2021 20:10:13 +0300") X-Provags-ID: V03:K1:pnijYma1LRN6BEGImO0kXU1UIczjouhiNIeyoJbPIp7Proi3lSz KVQ6xCeVzhMrf6Dk65OU+YCulPntpJwDtxd6gTOFAtEs3bbCmrdtyodILJ17FfOXkwQTICO usZ1lFkxtLReWR/Yq3Ewr6SDAkqy9zQz7Q0B2vqCBm8Kd+JDVsDzVK903sFsPxR3+WlP4CY 96qhVZMnt4dfBV8I151tg== X-UI-Out-Filterresults: notjunk:1;V03:K0:r5c8r29RUqw=:SlodGS0dWMFd6bvlx9+FyB spNh1KN/V6pJ2iHbtmPWyjtCtDMesHNx5DYGUYVy/NtuIzyNbPeEObFwsOfsqIyqU/yGtwazc W5tZhjZM5qrp5PK8B6f92442beR+QwCr8DhO7YlsVmbxuZvkMLbKOcGkTWaRPu2cfueXDeuFi fjWqLqjS19JZRickYjb8mns9tWdna5Ug4RggVPvj7qSAABBAoLuU4oKVyPv6eh8uTNBBM8P23 SLSk1ft5PsiW1CY6Ke7qHCVh3gZhNU/XPzvzLCEYnh703ZcO3kIKhk2bbaBLJz3SeJGt/0Cgz g+GDgTr/0Nh3JqVKvhJ6TNR5x/IXtOMfM/kpgEbINrvJO7JavM1yfvvWjCtvmdHZn7i+SdyfQ NAlaAHxXVyn9z61SwqgNygrwiLzWSVcWmRsoJ8E+YhaYPSP+MqWZkCseIteCzCK0UScl9IIDu 5ycJW/E5f7KaNzcM8Jaryi01EIWzI06PCFel2LTj8SqyiXxrei1ZF6bxBYS1FJDaez28UB3nl 1c2lGozLpf8gHay/fB1zsnlBxo7BGHVNuWIMvkW/5Vr7splZk9BEubc9VLhnVfMEMgF98dMo3 cYsP8HnmybvgcHL5Ur6UGmJgSljv7UNAS67xQuFpzOnySCgXyhTOPs+vMFaXnmBnpINjub9Bz APT3DjC33Kmh3o9tu2PXso1qht/tG2Rdq0Smi/W0FHKqpI84fEjl2YLOSBsBQ329QL9Ix3qKq cDVUYyja3N6ngokwJ6mWaFU/uhgoKtvTYW1mUB8ko6C2kB4CHPbZ/GSvviLRLEoabWNIxFsx X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212842 Archived-At: On Fri, 27 Aug 2021 20:10:13 +0300 Juri Linkov wrote: >>> - (vc-git-command nil 0 (vc-git--literal-pathspecs (list old new)) "mv" >>> "-f" "--")) >>> + (vc-git-command nil 0 (list old new) "mv" "-f" "--")) >> >> Looks like the proper fix, thanks. Feel free to push it right away, if >> you like. > > Pushed now. > > I wonder how many git commands still remain broken > and will go unnoticed to the release? Such as > vc-git-delete-file and vc-git-mark-resolved, etc. > >> Would be great to add some test, though. vc-tests.el currently doesn't >> exercise vc-rename-file at all. > > Indeed, covering all git commands will avoid the danger of breaking > some commands. I just discovered that some code I have that uses vc-print-log-internal broke after the literal-pathspecs change; specifically, my code passes a directory name beginning with "~/" to vc-print-log-internal, and this had worked fine till that change, which broke it, and I found I have to wrap the directory name in expand-file-name to make the code work again. Is this expected fallout from that change or was I perhaps misusing vc-print-log-internal and was just lucky that it had worked before? Steve Berman