From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el Date: Mon, 30 Aug 2021 09:46:26 +0100 Message-ID: <87a6kzl3q5.fsf@gmail.com> References: <87bl5hm5qj.fsf@gmail.com> <8dfca367-baa8-c4ae-8e6b-8ca41d5a63d6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21338"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50244@debbugs.gnu.org, p.stephani2@gmail.com, theo@thornhill.no To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 30 10:47:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKcwj-0005KI-Sj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Aug 2021 10:47:13 +0200 Original-Received: from localhost ([::1]:46704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKcwi-0002aw-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Aug 2021 04:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKcwY-0002ZU-F9 for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 04:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKcwY-00080p-7H for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 04:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKcwY-00021z-1I for bug-gnu-emacs@gnu.org; Mon, 30 Aug 2021 04:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Aug 2021 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50244 X-GNU-PR-Package: emacs Original-Received: via spool by 50244-submit@debbugs.gnu.org id=B50244.16303131987776 (code B ref 50244); Mon, 30 Aug 2021 08:47:01 +0000 Original-Received: (at 50244) by debbugs.gnu.org; 30 Aug 2021 08:46:38 +0000 Original-Received: from localhost ([127.0.0.1]:58085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKcwA-00021M-Ij for submit@debbugs.gnu.org; Mon, 30 Aug 2021 04:46:38 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKcw8-000216-Qh for 50244@debbugs.gnu.org; Mon, 30 Aug 2021 04:46:37 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id t15so15072144wrg.7 for <50244@debbugs.gnu.org>; Mon, 30 Aug 2021 01:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=UrBOZ1u37dzIeN72QEyr18cJ3dehnn5XE8+1UTIGpkU=; b=MYtf8jxoAJGIaEkru0S5gA+s4wp/dUGZWorTy/wGu1COnkePGskRnymbI0N4iuaP73 gFNLf+W57J9IXng8qzMMZtJ0eMG6NdhJkz0U88Cj5V3hVDqQGENkE9/BhmwZiyi0p1bD bGOSMAI+3js/kLCrhuAvtyOZxMprUuqQ3X0OMmFOpeVdad3eS9ETsiJhBX0CGTBlcqIq WaqQ9l9mTgQXQ3vic7Tq15HvShazWaVSME8W8gvHNVdFXxoGnmZ41NJXPcxxvTZP6KTL gbi8kOX2bsutHtdaNuSgnya0bjJMq2Vet6cp5vV9pj9f3Q9fto0jsGK4YUu479RxEOAR 1mXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=UrBOZ1u37dzIeN72QEyr18cJ3dehnn5XE8+1UTIGpkU=; b=rcF1MtcTuZ31l1NAGmIIbt1ryHpFzO3yewYdyp3GKM7MXHUt6tSvVKwiT+MVk9tIRI ibyFEyldTxgSRAGue0FhmNLg3gtJrdaAxgH6wrpW/pMyFhPaCuyz5rFYx/JUTb7E+soC TGFjXDZMcOkxgV9jaU1Mzm8ZbEahfNwoS2bru3Nyo/HKEqx8OJih2JRqlQJRJaB1OT+F jO12QoF9iC4chZz5NNV6CWq9DX3oI+QygRdpgUX2Li76mea7UvL4C9H0u2tGQP8FEdM5 b5dwOxhKnEPijUmNHLXfD6V/+Dqu1i6mwVs0wx41TEMwUKRV8VuLTgh8QEIEdg7LBxBw OgRA== X-Gm-Message-State: AOAM5317b0G8v5axZL/7tiRQ3CwVB05m1FWk5VdTnoitj4ttNkQm3Jql zbNOmDAA3LKEvKejjN104hc= X-Google-Smtp-Source: ABdhPJzKvarglOBrMKM5k61IPke5IDV+I1FVOQD+4A5QZhh65jKT4ej8KCsefgaGpO//JAAXFAy1vw== X-Received: by 2002:a05:6000:1623:: with SMTP id v3mr3298099wrb.288.1630313190754; Mon, 30 Aug 2021 01:46:30 -0700 (PDT) Original-Received: from krug (a94-133-55-158.cpe.netcabo.pt. [94.133.55.158]) by smtp.gmail.com with ESMTPSA id z137sm20199200wmc.14.2021.08.30.01.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 01:46:30 -0700 (PDT) In-Reply-To: <8dfca367-baa8-c4ae-8e6b-8ca41d5a63d6@yandex.ru> (Dmitry Gutov's message of "Mon, 30 Aug 2021 02:27:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213009 Archived-At: Dmitry Gutov writes: > On 29.08.2021 03:53, Jo=C3=A3o T=C3=A1vora wrote: > Is the idea to build a list of "project errors" using sources of type > 1? No. The current idea is, in short, to not have Flymake discard information of what you call "type 2" (and which I described in my email). As I wrote there, examples of discarded information can be project-wide diagnostics sent by LSP servers on server startup, among others. For a non-LSP example, consider references to errors .c in files when editing .h files. In other words, this is a "best effort service" by flymake.el: the topic of this bug#50244 is _not_ to augment flymake.el to somehow change the way that diagnostics are requested so that somehow more of what you call "type 2" can be gathered. To be clear, after this feature is done, diagnosics are _still_ requested per-buffer. Eminently, on buffer changes and less frequently on occasions like visiting a file. The idea is simply to not discard what I called "piggy-backed" or "sideband" information about diagnostics in other places, which will frequently originate from the aforementioned per-buffer requests. > But I thought the original discussion was about errors from sources of > type 2? Then the whole list provided by the source already belongs to > the same project (how the LSP server understands it, if we use the LSP > example). Is there a need for further filtering? Yes, and even in the .c/.h non-LSP example that is true. But depending on what data-structures are employed (I'm still thinking about them), utilizing project.el's basic features for composing M-x flymake-diagnostics-buffer _may_ come in handy. This is pretty secondary at this point, in my view at least. I first want to have the information recorded and correctly updated in Elisp memory. Then I will think about how to present it to the user. Jo=C3=A3o