From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications Date: Fri, 17 Sep 2021 00:45:24 -0400 Message-ID: <87a6kbn72z.fsf__37836.2035656878$1631854001$gmane$org@gnu.org> References: <5495728.XOh7uYVVfo@ravel> <4764688.dQ8sKJKaaQ@ravel> <87sg01jzgk.fsf_-_@neverwas.me> <87ee9r4io8.fsf@neverwas.me> <87v931cck5.fsf@gnu.org> <87ilz03d4t.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23754"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Olivier Certner , emacs-erc@gnu.org, Lars Ingebrigtsen , "J.P." To: 46777-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 17 06:46:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mR5lh-0005xv-Hp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 06:46:33 +0200 Original-Received: from localhost ([::1]:55318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR5lf-0005qu-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 00:46:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR5lC-0005qE-AC for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 00:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR5lC-00075G-1a for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 00:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR5lB-0004RC-Tt for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 00:46:01 -0400 Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Sep 2021 04:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 46777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 46777@debbugs.gnu.org, bandali@gnu.org, ocert.dev@free.fr Original-Received: via spool by 46777-done@debbugs.gnu.org id=D46777.163185393617017 (code D ref 46777); Fri, 17 Sep 2021 04:46:01 +0000 Original-Received: (at 46777-done) by debbugs.gnu.org; 17 Sep 2021 04:45:36 +0000 Original-Received: from localhost ([127.0.0.1]:58259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR5kl-0004QP-TD for submit@debbugs.gnu.org; Fri, 17 Sep 2021 00:45:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR5ki-0004QB-F1 for 46777-done@debbugs.gnu.org; Fri, 17 Sep 2021 00:45:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50414) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR5kb-0006ZB-HG; Fri, 17 Sep 2021 00:45:25 -0400 Original-Received: from [2607:fea8:3fdf:f2d9:a4cf:ca3d:20e1:2f59] (port=53154 helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR5kb-0001MT-4q; Fri, 17 Sep 2021 00:45:25 -0400 In-Reply-To: <87ilz03d4t.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214522 Archived-At: Hi all, Lars Ingebrigtsen writes: > Amin Bandali writes: > >> 2. gradually phase out the function if we must: either declare it >> obsolete and make it a wrapper around a new function with the >> desired API > > This is usually the way to handle things like this, and it looks like > the right solution here, too. Thanks, sounds good. * * * J.P. writes: > Amin Bandali writes: > >> 1. change the function's arguments in a backwards-compatible way >> (i.e. by adding new &optional args as needed), and ignore the >> arg we don't need anymore (the password in this case, and >> make sure we don't accidentally expose it instead of a nick); > > I guess ignoring the password arg means some folks currently using this > entry point in lisp code may have to call `erc-nickserv-send-identify' > directly instead, depending on their needs. Works for me, but if that's > the plan, I don't think the version I sent fits the bill entirely. Right. I think your *not* ignoring the password here is actually more familiar and desirable, and I prefer it over what I'd suggested. :) >> From a quick look at J.P.'s revised version of Olivier's patch, it >> looks quite favourable to me > > Um, that was mostly me trying out my bandali impersonation (blasphemous, > I know). Ha, you give me too much credit. :) Okay so having tested and reviewed J.P.'s revised patch, it looks good to me; so I went ahead and merged it with some minor tweaks, including listing J.P. as co-author: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c6eb114a42922af18818dce7317238e0af776958 Thank you all for your help and bearing with me until I finally got around to this.