From: Amin Bandali <bandali@gnu.org>
To: 46777-done@debbugs.gnu.org
Cc: Olivier Certner <olce.emacs@certner.fr>,
emacs-erc@gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
"J.P." <jp@neverwas.me>
Subject: bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications
Date: Fri, 17 Sep 2021 00:45:24 -0400 [thread overview]
Message-ID: <87a6kbn72z.fsf__37836.2035656878$1631854001$gmane$org@gnu.org> (raw)
In-Reply-To: <87ilz03d4t.fsf@gnus.org>
Hi all,
Lars Ingebrigtsen writes:
> Amin Bandali <bandali@gnu.org> writes:
>
>> 2. gradually phase out the function if we must: either declare it
>> obsolete and make it a wrapper around a new function with the
>> desired API
>
> This is usually the way to handle things like this, and it looks like
> the right solution here, too.
Thanks, sounds good.
* * *
J.P. writes:
> Amin Bandali <bandali@gnu.org> writes:
>
>> 1. change the function's arguments in a backwards-compatible way
>> (i.e. by adding new &optional args as needed), and ignore the
>> arg we don't need anymore (the password in this case, and
>> make sure we don't accidentally expose it instead of a nick);
>
> I guess ignoring the password arg means some folks currently using this
> entry point in lisp code may have to call `erc-nickserv-send-identify'
> directly instead, depending on their needs. Works for me, but if that's
> the plan, I don't think the version I sent fits the bill entirely.
Right. I think your *not* ignoring the password here is actually more
familiar and desirable, and I prefer it over what I'd suggested. :)
>> From a quick look at J.P.'s revised version of Olivier's patch, it
>> looks quite favourable to me
>
> Um, that was mostly me trying out my bandali impersonation (blasphemous,
> I know).
Ha, you give me too much credit. :)
Okay so having tested and reviewed J.P.'s revised patch, it looks good
to me; so I went ahead and merged it with some minor tweaks, including
listing J.P. as co-author:
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c6eb114a42922af18818dce7317238e0af776958
Thank you all for your help and bearing with me until I finally got
around to this.
next prev parent reply other threads:[~2021-09-17 4:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 17:33 bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications Olivier Certner
2021-02-25 17:38 ` Olivier Certner
2021-02-25 17:47 ` Basil L. Contovounesios
2021-02-25 18:22 ` Olivier Certner
2021-06-08 2:23 ` J.P.
[not found] ` <878s3l6qms.fsf@neverwas.me>
2021-06-09 13:30 ` Olivier Certner
2021-06-10 3:59 ` J.P.
2021-07-06 14:52 ` bug#46777: Updated patch Olivier Certner
2021-07-22 12:29 ` bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications Lars Ingebrigtsen
2021-07-30 12:27 ` Amin Bandali
2021-07-30 12:43 ` Lars Ingebrigtsen
2021-07-26 7:39 ` J.P.
[not found] ` <87sg01jzgk.fsf_-_@neverwas.me>
2021-09-14 9:20 ` J.P.
2021-09-16 5:30 ` Amin Bandali
[not found] ` <87v931cck5.fsf@gnu.org>
2021-09-16 12:42 ` Lars Ingebrigtsen
2021-09-17 4:45 ` Amin Bandali [this message]
[not found] ` <87a6kbn72z.fsf@gnu.org>
2021-09-17 7:57 ` Olivier Certner
2021-09-19 15:26 ` Amin Bandali
2021-09-17 2:16 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87a6kbn72z.fsf__37836.2035656878$1631854001$gmane$org@gnu.org' \
--to=bandali@gnu.org \
--cc=46777-done@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=jp@neverwas.me \
--cc=larsi@gnus.org \
--cc=olce.emacs@certner.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).