From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39799: 28.0.50; Most emoji sequences =?UTF-8?Q?don=E2=80=99t?= render correctly Date: Tue, 21 Sep 2021 16:43:17 +0200 Message-ID: <87a6k6gfay.fsf@gmail.com> References: <83lfongp4p.fsf@gnu.org> <835zfrglu5.fsf@gnu.org> <83wo86g8pg.fsf@gnu.org> <83h7zafzwh.fsf@gnu.org> <838skmfox6.fsf@gnu.org> <87h7efhtiz.fsf@gmail.com> <83zgs6xhqs.fsf@gnu.org> <87o88mgkj5.fsf@gmail.com> <83tuiexeky.fsf@gnu.org> <87k0jaghlb.fsf@gmail.com> <83mto6xb84.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, 39799@debbugs.gnu.org, mfabian@redhat.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 21 16:44:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSh0I-00007p-Ql for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 16:44:14 +0200 Original-Received: from localhost ([::1]:43472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSh0H-0003Al-KP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 10:44:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSh06-00037u-L4 for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 10:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSh06-0000rb-Bj for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 10:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSh06-0001vw-2h for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 10:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Sep 2021 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39799 X-GNU-PR-Package: emacs Original-Received: via spool by 39799-submit@debbugs.gnu.org id=B39799.16322354067372 (code B ref 39799); Tue, 21 Sep 2021 14:44:02 +0000 Original-Received: (at 39799) by debbugs.gnu.org; 21 Sep 2021 14:43:26 +0000 Original-Received: from localhost ([127.0.0.1]:47468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSgzW-0001up-DV for submit@debbugs.gnu.org; Tue, 21 Sep 2021 10:43:26 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:34722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSgzV-0001ua-5J for 39799@debbugs.gnu.org; Tue, 21 Sep 2021 10:43:25 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id t8so32939141wri.1 for <39799@debbugs.gnu.org>; Tue, 21 Sep 2021 07:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=oMWd7t3Iy3yIDy9hRd+1LlKUNkL5qQojaYXt5nj9cMc=; b=P0wnlRZC3nVOcbkPxR6izTMCMQkFtYyFif2U4WFKkN/1ZZBMT6AQM1rzsN7djVCi3O 8tipDvGHS9TSJfd0rfgCc3VFDLxDHm1B3Ot1nhag2hIetkmeOE4yrQr9o9tIWoXugUO+ yNYMtlmaHIoDXFkRnJBUsdOGaNXoL9N5WI6YIDEeH/S0bSSL8jMtCVIcptfiyzeqFHSF EKRzC+yvVAW3vf4GDgRehcDBYWPAo+zeMJ3fR6x4fzoPfZkgD/W83JVNFnUr2OPriRD0 jei9k8D+cQ76gL4QJbrIS9W/WwAntCQKWaKO93SNZwLELVe9WQpoHOXvgDX7O+MxEI2y 4gzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=oMWd7t3Iy3yIDy9hRd+1LlKUNkL5qQojaYXt5nj9cMc=; b=BRdHTg0ujBh7jeq4HrjBpPz6oHH5/5ytLDio14rYszFV3lYrNdrnlEKA0E9NzqNqnk cpz4iYjclPf1a5DT9Byz54qoVCbO2bTkSt6VdHW497VYRfeQwtk1SQUd41WEBQS2l+Ut i2524RajmnKKgjzoCGAqPS7c3U06+9jNbxdCDbHr2QPcGuRkL+RGPlt+RuY+JWgs+axp Gy5zdolpVMqydm4SH6lRw6M9krP2TceQ8E+uJ+pzE59AXeZpRjGGr35sReEZ8X7v5oor tPPxNGySeEs2XCi7RsLkUARDzLHsEE1Vm//omByNIyOdz1B3ACawT7NrSWbH7sSTKRYX l5Mg== X-Gm-Message-State: AOAM5323AIWJos4ZBZVHWp7jBOzzEWNc0twRV1nl/2t/8kmRDR202Kjv 1YzotwR7I3PREsun5Dz6L2TsJi2Q9Bc= X-Google-Smtp-Source: ABdhPJxjG5ewsky/voBHoNilaEY15ZLyGHU9/QLTbzlU6p/z42t0JSv5iTwj+tVQqoqJLnWkfArIiQ== X-Received: by 2002:adf:a31a:: with SMTP id c26mr36378069wrb.307.1632235398724; Tue, 21 Sep 2021 07:43:18 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id r9sm11814608wru.2.2021.09.21.07.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 07:43:18 -0700 (PDT) In-Reply-To: <83mto6xb84.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Sep 2021 17:19:23 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214981 Archived-At: >>>>> On Tue, 21 Sep 2021 17:19:23 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eli Zaretskii , rgm@gnu.org, 39799@debbugs.gnu.o= rg >> Date: Tue, 21 Sep 2021 15:53:52 +0200 >>=20 Mike> It does work with hb-view. >>=20 >> It=CA=BCs a problem with the way we generate the auto composition >> sequences. If I remove the ZWJ sequences for eg 1f469, then all the >> skin tone sequences for 1f469 work Eli> Not sure I understand. The sequence U+1F4F9,U+1F3FD indeed does n= ot Eli> appear in emoji-zwj.el, but it does appear in emoji-sequences.txt. Eli> However, the string "=F0=9F=91=A9=F0=9F=8F=BD" doesn't match the r= egexp in the Eli> composition-function-table's slot for U+1F4F9. Why is this? Because for skin tones we index on the modifier, and use lookback: ;; Skin tones (set-char-table-range composition-function-table '(#x1F3FB . #x1F3FF) (nconc (char-table-range composition-function-table '= (#x1F3FB . #x1F3FF)) (list (vector ".[\U0001F3FB-\U0001F3FF]" 1 'compose-gstring-for-graphic)))) I=CA=BCve just tried adding "\N{U+1F469}\N{U+1F3FE}" to the composition function table regexp for U+1F469 manually, and now I get correct composition. That means we could process the RGI_Emoji_Modifier_Sequence entries from emoji-sequences.txt with emoji-zwj.awk and add them, indexed on the base character (and remove the above code). I=CA=BCd still like to understand where things are going wrong though. Robert --=20