From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#51107: 29.0.50; Add ERC version header to protocol logs Date: Fri, 08 Oct 2021 18:22:08 -0700 Message-ID: <87a6jj9em7.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32326"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) To: 51107@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 09 03:23:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZ14x-0008B3-1e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Oct 2021 03:23:11 +0200 Original-Received: from localhost ([::1]:34140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZ14v-0003jy-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 21:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZ14p-0003jp-6v for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 21:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZ14o-0003JB-Vp for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 21:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZ14o-0005rS-I7 for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 21:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Oct 2021 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51107 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163374254322465 (code B ref -1); Sat, 09 Oct 2021 01:23:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Oct 2021 01:22:23 +0000 Original-Received: from localhost ([127.0.0.1]:52170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZ14A-0005qH-I6 for submit@debbugs.gnu.org; Fri, 08 Oct 2021 21:22:22 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZ148-0005q9-UA for submit@debbugs.gnu.org; Fri, 08 Oct 2021 21:22:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZ148-0003iz-OX for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 21:22:20 -0400 Original-Received: from mail-108-mta255.mxroute.com ([136.175.108.255]:41615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZ146-00022G-Ha for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 21:22:20 -0400 Original-Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta255.mxroute.com (ZoneMTA) with ESMTPSA id 17c62a4aa580000b55.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 09 Oct 2021 01:22:11 +0000 X-Zone-Loop: 623c491d979295a2ab46370f5415fb81575b79ac1570 X-Originating-IP: [149.28.56.236] X-AuthUser: masked@neverwas.me X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, URIBL_BLOCKED=0, FROM_HAS_DN=0, HAS_ATTACHMENT=0, MIME_GOOD=-0.1, TO_DN_NONE=0, RCPT_COUNT_ONE=0, NEURAL_SPAM=0, RCVD_COUNT_ZERO=0, FROM_EQ_ENVFROM=0, MIME_TRACE=0, MID_RHS_MATCH_FROM=0] Received-SPF: pass client-ip=136.175.108.255; envelope-from=jp@neverwas.me; helo=mail-108-mta255.mxroute.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216744 Archived-At: --=-=-= Content-Type: text/plain Severity: minor Tags: patch I think having ERC's version present in protocol logs would be helpful. But I opted *not* to include the full monty, namely, ERC-Version: ERC 5.4 (IRC client for GNU Emacs 29.0.50) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ even though parens typically denote comments in these sorts of headers. This, mainly because the logical follow though would be losing the subsequent Emacs-Version: 29.0.50 to avoid being redundant. But IMO, keeping that separate is more structured and perhaps more useful. Thanks. In GNU Emacs 29.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-10-07 built on localhost Repository revision: b506c5b217d4adf68013c15be0d1b16189de089b Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Fedora 34 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3 --with-gpm=no --with-xwidgets --with-modules --with-harfbuzz --with-cairo --with-json build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu CC=gcc 'CFLAGS=-O0 -g3' LDFLAGS=-Wl,-z,relro PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-extra seq gv subr-x byte-opt bytecomp byte-compile cconv cl-print thingatpt help-fns radix-tree help-mode cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads xwidget-internal dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 58657 6261) (symbols 48 6905 1) (strings 32 21452 1550) (string-bytes 1 670721) (vectors 16 14458) (vector-slots 8 193458 7961) (floats 8 28 34) (intervals 56 279 0) (buffers 992 11)) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-erc-erc.el-Add-ERC-version-to-protocol-log.patch >From 54a9624f7e45996364afb5410020fdebfb077d47 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Fri, 8 Oct 2021 17:28:39 -0700 Subject: [PATCH] ; * lisp/erc/erc.el: Add ERC version to protocol log --- lisp/erc/erc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 3462aa4db0..4a86fa712a 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -2388,6 +2388,7 @@ erc-toggle-debug-irc-protocol (let ((inhibit-read-only t) (msg (list (concat "Version: " erc-debug-irc-protocol-version) + (concat "ERC-Version: " erc-version) (concat "Emacs-Version: " emacs-version) (erc-make-notice (concat "This buffer displays all IRC protocol " -- 2.31.1 --=-=-=--