From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use Date: Sun, 24 Oct 2021 19:48:54 +0200 Message-ID: <87a6iy71q1.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32934"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51368@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 24 19:52:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mehfe-0008LW-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 19:52:34 +0200 Original-Received: from localhost ([::1]:59182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mehfc-00055e-V5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 13:52:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mehdD-000189-IT for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 13:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mehdC-0000tR-Fs for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 13:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mehdC-0003ZY-9z for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2021 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51368 X-GNU-PR-Package: emacs Original-Received: via spool by 51368-submit@debbugs.gnu.org id=B51368.163509774713654 (code B ref 51368); Sun, 24 Oct 2021 17:50:02 +0000 Original-Received: (at 51368) by debbugs.gnu.org; 24 Oct 2021 17:49:07 +0000 Original-Received: from localhost ([127.0.0.1]:40708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mehcJ-0003YA-HZ for submit@debbugs.gnu.org; Sun, 24 Oct 2021 13:49:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mehcH-0003Xb-1e for 51368@debbugs.gnu.org; Sun, 24 Oct 2021 13:49:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bBholxVRXpD5nm7w6nlzad4hLsjYR5KIRMyAQUP7yuU=; b=sBU4mMjVgXPEAtM7AqrRFDzQ+P S1lfcHe8sjveqguFChlR9hZmYtltnlu6mWtii24ANs1fqBTim5t3O6pZu93Crs7JDF/KiIoV3P5yv s7XHlrTV1qtEwf9N1r0IilZAtNBW2lkrgY8M5xpUXVSs5mUzYqwIxWF+N6taoyT+TBnc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mehc7-00011p-8A; Sun, 24 Oct 2021 19:48:58 +0200 In-Reply-To: (Philipp Stephani's message of "Sun, 24 Oct 2021 09:52:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218158 Archived-At: Philipp Stephani writes: > This form demonstrates a few incorrect uses of `cl-case': > > (cl-case a > (nil 0) ; doesn't match anything > (t 1) ; matches everything, but too early > ('foo 2)) ; matches `quote' in addition to `foo' > > It would be nice if `cl-case' would signal an error or at least warn > about these at macroexpansion time, since they are somewhat subtle and > easy to get wrong. An error from the second case would be nice, and a warning on the first case, but the third case: (macroexpand '(cl-case a ('foo (message "foo")))) => (cond ((cl-member a ''foo) (message "foo"))) and (equal ''foo (list 'quote 'foo)) which, sure, whatever. But I guess the question is whether we can actually warn about that, because to the reader, the two forms are equivalent? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no