From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings Date: Wed, 24 Nov 2021 08:30:55 +0100 Message-ID: <87a6huvwls.fsf_-_@gnus.org> References: <829C7136-B97A-47CB-9F35-76EF73D971E5@icloud.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52067@debbugs.gnu.org To: Paul Maragakis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 24 08:37:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpmqK-0008Ur-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 08:37:24 +0100 Original-Received: from localhost ([::1]:33588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpmqJ-0004cf-FO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 02:37:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpml8-0005JE-Ii for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 02:32:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpml8-0006bJ-8R for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 02:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpml8-0000XQ-5f for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Nov 2021 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52067 X-GNU-PR-Package: emacs Original-Received: via spool by 52067-submit@debbugs.gnu.org id=B52067.16377390701999 (code B ref 52067); Wed, 24 Nov 2021 07:32:02 +0000 Original-Received: (at 52067) by debbugs.gnu.org; 24 Nov 2021 07:31:10 +0000 Original-Received: from localhost ([127.0.0.1]:52895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpmkH-0000W5-U0 for submit@debbugs.gnu.org; Wed, 24 Nov 2021 02:31:10 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:54108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpmkC-0000VV-UE for 52067@debbugs.gnu.org; Wed, 24 Nov 2021 02:31:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xI4SGX0EBUG4rvTZKh5zpGTlyu6Ka0oBp24a4r8H2j8=; b=ICuZUuMHpcesq/4+Xopipxlbij DONEKzzCtITfLWpHC8Ufoam1nIcQeVLv9AKKIzpBKA60dZeBySJ/cqbNrdeaNCrxVK7KItwD9AUrw ei/T14TaFkHh7iwGtgFtXPFnC9ls8jD917B7tSoiaVEnFwHVHTy9xzTBVuElzUoRteeI=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpmk4-0007aB-3C; Wed, 24 Nov 2021 08:30:58 +0100 X-Now-Playing: Irreversible Entanglements's _Open The Gates_: "Keys to Creation" In-Reply-To: <829C7136-B97A-47CB-9F35-76EF73D971E5@icloud.com> (Paul Maragakis's message of "Tue, 23 Nov 2021 22:51:07 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220707 Archived-At: Paul Maragakis writes: > The logic in string-glyph-split expects the first two elements in the result > from find-composition-internal to give the start and end of a multibyte grapheme > and return nil when there is a regular character at position POS. However, this > isn't always the case. Yup. Paul Maragakis writes: > The following code fixes this bug, though there might be better ways > to fix it for someone who understands the domain. Thanks. `find-composition' takes a the LIMIT parameter, and that'll make it avoid searching back into the bit of the string that we've already handled. So I did that instead in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no