From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies Date: Sun, 06 Feb 2022 08:22:49 +0000 Message-ID: <87a6f4ieue.fsf@posteo.net> References: <8735kx3zct.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12217"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, monnier@iro.umontreal.ca, pu.stshine@gmail.com To: 53805@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 06 09:24:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGcqE-000304-7f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 09:24:14 +0100 Original-Received: from localhost ([::1]:53944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGcqD-0004Yc-3z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 03:24:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGcq2-0004Vn-P8 for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 03:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGcq2-0002Pa-F4 for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 03:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGcq2-00014U-CA for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 03:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Feb 2022 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53805 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Philip Kaludercic , Stefan Monnier , 53805@debbugs.gnu.org, Xingyu Pu Original-Received: via spool by submit@debbugs.gnu.org id=B.16441357894052 (code B ref -1); Sun, 06 Feb 2022 08:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Feb 2022 08:23:09 +0000 Original-Received: from localhost ([127.0.0.1]:36334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGcpB-00013I-35 for submit@debbugs.gnu.org; Sun, 06 Feb 2022 03:23:09 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGcpA-00013C-B3 for submit@debbugs.gnu.org; Sun, 06 Feb 2022 03:23:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGcpA-0003bn-3L for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 03:23:08 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:51793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGcp5-0002H8-Op for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 03:23:07 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 32931240027 for ; Sun, 6 Feb 2022 09:22:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644135773; bh=eOtWK1POyEAF3PqMabo6sQquJJb0A0dY0FGeNzT3ZO0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=EJIajUdglhEp9ZF+O+RnLfX5KStl1g0HYmf0Zqc6MPIuhHl6PRqL1m4AZnCVjj+DD WGHukBgquP1SDL0z2uYuCSHsXz3BEVqsybhup6VDaSNvAUg2rkZ1sbmnZktUCMg3FC vDji/tgv5HEifBXn8ugkiKMIcz0EPGkzmINb00RYSb0KhUOpMdCqVkt40mmeSr+XdX I8d8FlHT2XZwhLEq88+lh/BfPX/zxvPpGGQEVmjcYo+JCQ5HD38yfI66fMVezedUPz A15eIO87VHXmeCEaPf80FhJSANBKtGtfDtlFmw8nVGiDGqrBi6Dp3aURGpWi/1xYVo pfBsTEL53LE6w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Js2Mb0WxZz6tmw; Sun, 6 Feb 2022 09:22:51 +0100 (CET) Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K In-Reply-To: (Stefan Monnier via's message of "Sat, 05 Feb 2022 17:16:11 -0500") Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226140 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> It seems to me that the core of the issue is that the ELPA build system >> overrides the existing -pkg.el files, by trying to infer all the package >> metadata from the main files (helm.el, helm-core.el). If as in the case >> of helm and helm-core these are empty, this leads to unexpected results. > > The best course of action is to fix the upstream. > They simply shouldn't have any `-pkg.el` file. I disagree, in the simple case of async package this didn't cause problems, but here it does because we have two packages (helm-core+helm) coming from the same git repo. > We will generate the `-pkg.el` in any case because we include more > information there than what the upstream will have put (e.g. we include > the commit id from which the tarball is built), So what is the problem? Just append the informations fetched from the upstream *pkg.el files to the *pkg.el file you are usually building. I guess it is what Melpa does more or less. > and and modifying files that are under version control tends to lead > to problems. You are anyway creating a new *pkg.el file so why do you want to modify the original *pkg.el files? -- Thierry