From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52209: 28.0.60; [PATCH] date-to-time fails on pure dates Date: Sun, 20 Feb 2022 13:25:16 +0100 Message-ID: <87a6elvi6r.fsf@gnus.org> References: <7c22f300-eedb-da65-db02-e82025ec2f48@cs.ucla.edu> <875yrjpp03.fsf@gnus.org> <25024.42989.718735.680188@orion.rgrjr.com> <871r26i5n0.fsf@gnus.org> <25028.53876.304365.706795@orion.rgrjr.com> <87zgoq2vwm.fsf@gnus.org> <25029.60989.564217.290743@orion.rgrjr.com> <87bl1428x5.fsf@gnus.org> <25031.40994.286546.498819@orion.rgrjr.com> <87ee5zzjpg.fsf@gnus.org> <25035.12991.328986.987982@orion.rgrjr.com> <87o84z782g.fsf@gnus.org> <25038.8156.470964.935330@orion.rgrjr.com> <87lezz5x92.fsf@gnus.org> <87h7an7bdm.fsf@igel.home> <25040.62646.635818.692654@orion.rgrjr.com> <87mtkd3vee.fsf@gnus.org> <25043.53490.928476.622599@orion.rgrjr.com> <87lezudw3q.fsf@gnus.org> <25046.8337.837242.510788@orion.rgrjr.com> <25105.33397.961104.269676@orion.rgrjr.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20322"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 52209@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 20 13:26:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLlI2-000578-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 13:26:10 +0100 Original-Received: from localhost ([::1]:52726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLlI1-0005Pz-C5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 07:26:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLlHv-0005Pp-C2 for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 07:26:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLlHu-0000r7-Hm for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 07:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLlHu-0003Vc-Ff for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 07:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Feb 2022 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52209 X-GNU-PR-Package: emacs Original-Received: via spool by 52209-submit@debbugs.gnu.org id=B52209.164535992713442 (code B ref 52209); Sun, 20 Feb 2022 12:26:02 +0000 Original-Received: (at 52209) by debbugs.gnu.org; 20 Feb 2022 12:25:27 +0000 Original-Received: from localhost ([127.0.0.1]:59501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLlHL-0003Uk-Bx for submit@debbugs.gnu.org; Sun, 20 Feb 2022 07:25:27 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:53892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLlHJ-0003UX-V1 for 52209@debbugs.gnu.org; Sun, 20 Feb 2022 07:25:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ttxiqYbAeZOZPfhXSqjA6KKv/6WYbZODNPOMHTXT/GU=; b=qePjk2yr1Hxh06Qe9qxDBids4Y VIYRjgM/VgLrAhCjUZbsCuAmqfFQIkkh5v7cQf//oWD8PaLCtH1FZVXs5Npow8BdwXa50v1OB+8jR K2pGyXfPaPWZaknbmbmvLlIUsVu73w8UczidihAkM/zFx9L/Nl4uWyKxI4jwfZvvj7/U=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLlHB-0001dE-EA for 52209@debbugs.gnu.org; Sun, 20 Feb 2022 13:25:20 +0100 In-Reply-To: <25105.33397.961104.269676@orion.rgrjr.com> (Bob Rogers's message of "Sat, 19 Feb 2022 18:51:17 -0500") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEU9NTViT02gg37/ //+reOmVAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YCFAwPKvxL7eoAAAGmSURBVCjPdZLBauMwEIbH RjI4pxLiUPe8hc1bmBCHHu3gEUinDViL5afoIe7ZBmvZ5rSGCKI+5Y7acwUGfZrR+P9/BPD9arDG sEQHwLVHNPr65yoBcvdOx1L8fhdUcQ7RevS9KCCx1iv06Mz2FXhifY/3ACOw2DpJYHcJwYkO0aF9 ThpgAqnicDL7A4GlylLPuwD7IbQRlAx4XVpJKsRwJjBP28kotR1uBwIlnJFKIAFrlbBaChpKQBsf HODtBYDgw6H4BKaVuH5Ygc1tAwxz4XoUZYM0DS3a+kG0Pf8LyXHxU93ors9ukIrF1FF1NnI9Q3qc TQVw1vJ0B3ZEM1UctdzPwNZDR5HUGgn4qTQWcWxxf4E0ORhSU+msYpAiCXUNZde9QKrV2+L7J2sN +/Sz0EexfJkLkaA1BM9GzI6khzbQOTYaS5w7giwn2wbLuSPbeVbO1U/6P91hjxtssoxTChfgfPJS DdNdIWnjloa/OROARUUnk3JsV8FCXPzbrdZjm8YzQAzjjzQufvEAEVQb6n1YxReqFMUji16/IALY AAGH4vs39R/6Aaur4OLNiwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMi0yMFQxMjoxNTo0Misw MDowMEtlZi4AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDItMjBUMTI6MTU6NDIrMDA6MDA6ON6S AAAAAElFTkSuQmCC X-Now-Playing: Meat Beat Manifesto's _Psyche-Out_: "Psyche-Out (version 1)" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227222 Archived-At: (Resending because bug report was archived.) Bob Rogers writes: > Here's what I have for this phase of the plan; let me know what you > think. It took longer than expected because it became a project unto > itself, and so my procrastinator kicked in, making it longer still. :-/ :-) Have you benchmarked your new implementation versus the current one? It's important that the parsing is performant, otherwise it'd slow down many things that parse a large number of date strings. Some minor comments about the code: > +(defsubst ietf-drums-date--ignore-char? (char) > + ;; Ignore whitespace and commas. > + (or (eq char ?\ ) (eq char ?\t) (eq char ?\r) (eq char ?\n) (eq char ?,))) In Emacs Lisp, we don't use Scheme-style predicate names -- we use -p instead. > +(defun ietf-drums-date--tokenize-string (string &optional comment-eof?) And the same with booleans -- we don't use foo? for those, but just foo. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no