From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#54126: 29.0.50; C-x x g doesn't always correctly revert SSHFS files Date: Thu, 10 Mar 2022 14:09:42 +0100 Message-ID: <87a6dyuf6x.fsf@gmx.de> References: <87v8x5mx7q.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12126"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54126@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 10 14:19:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSIhW-000317-8Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Mar 2022 14:19:30 +0100 Original-Received: from localhost ([::1]:36838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSIhV-0002kR-BN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Mar 2022 08:19:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSIYM-0000c2-K6 for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 08:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSIYM-00010f-9I for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 08:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSIYM-0002OH-1l for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 08:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Mar 2022 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54126 X-GNU-PR-Package: emacs Original-Received: via spool by 54126-submit@debbugs.gnu.org id=B54126.16469177929166 (code B ref 54126); Thu, 10 Mar 2022 13:10:01 +0000 Original-Received: (at 54126) by debbugs.gnu.org; 10 Mar 2022 13:09:52 +0000 Original-Received: from localhost ([127.0.0.1]:33569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSIYB-0002Nm-KE for submit@debbugs.gnu.org; Thu, 10 Mar 2022 08:09:51 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:38841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSIYA-0002NX-30 for 54126@debbugs.gnu.org; Thu, 10 Mar 2022 08:09:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1646917783; bh=FW9FSO5/wDiQeh7n+0klOQIJMIkb/SBaCVCYeCmYH7A=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=V8zrkDf9OA6Mu8IwwWT8G3/EHiX4GrIzWxN4upJUmeXTd1orewRS1S48nmODmKdUN +/BFFgHqUsu16lByYMu7pHiD/RTwPBfUTCifMbBZ6jfD0msdVWzrD2etkc/qvi2zuE 3ldV6+mNhdiJ0fppAOj+UEAh0Qa23iTihaiMty8E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.243.107]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MuDXz-1oHVgw1yG5-00ucwi; Thu, 10 Mar 2022 14:09:43 +0100 In-Reply-To: <87v8x5mx7q.fsf@gmx.de> (Michael Albinus's message of "Wed, 23 Feb 2022 16:14:33 +0100") X-Provags-ID: V03:K1:8ibbKhu7F8iM4Qs3B4NsFL0o6Ai4UnHNtNKzgeXM5DQKqI1lJP9 3DE/GZZp+kyxOXjk+XuGVwR8dR6cRz0myaEL685s+24IXWtAjWUhSuNGyRyhQsrvIAkiMIO T56qSCLX6zNoH1DkNqZzsjn/Rdv7lmUAkS1qn1S9keHPbDsDS3hH1aDijg8skxwg4ekBFG+ QfqN+P4m0QCj1jt1qD7ug== X-UI-Out-Filterresults: notjunk:1;V03:K0:MlEpli3Ugu8=:oJP0CcLK05fm2olqaSez04 wjZcSzeQGN+fqYi3tbHGU2KuioZFZ9tJa4azWabVUQ98luo/YGGhpl2w9iMzM/x34pJJ/LBby R8BfsuRJHlRdWIuh9HzKBFELAse3Oe5SmhvnqEbIApWePEkGo1P0wtgYHihwc24cHfLHh03CY A41xqPCmLBFuNXPWiN/ghJyf/PQtvfmf8OBge5KekEqEqrz7PjJ0fkG91rWB89x6LIDv7IBbR hqxQXv5/E7YE6+EORdZKM5bo/GtGlXIFXqpAPOu4LulbVr8IILnWCjL0diTkj0vDMu7AYSR6C cix7z5x5FZXJkEN+RGx9noRydeY34SO8PQDtHy+z1WKQqqFavO+eYaR2gNUqdR+o0auwi0SDe /f3oCDBHMc8/2/OuKQFX4IEiVahY6i4Hwu7EV6i37G1qlymgXM85Hd2CwFmU2LSTtidqpBJVK n1hAn9lH6eP8mhlHqQzIQnJA6dtiiEL5UYC8DBWS3HMnxgSynEBrBM2DdmsROG5ppS6U9TfF1 PEWArLgWE0HDjzlfauSU0o+0aottSxmyz0NSSjhE0eYZjRW/2+a8r4v44S08ybMi7AUJfhpRQ s6hBk6ONXAGiUEKSqWFJKLEYfotHY3nbOZdKNoT9NXIOPZT8ZR1S0KzUwuaquox2c7ts3hZYv vAflYX4+VmCYGBnFCDQEVWZfUqgMnF1LUAN3Xvjy4GeFva0VzP9OHjOqmiLpINjPBRfE775ct FN7FXqXzKgicY1AwgXKTsQEGf4TEs3o0L1atR2xzdKpZufC9NolSrT9zUfxTNydQmpcJf05e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228188 Archived-At: --=-=-= Content-Type: text/plain Michael Albinus writes: Hi Philipp, >> At least on my system the following happens often, but not always: >> >> Create some file whose contents don't really matter. In my case: >> >> $ cat /tmp/a.c >> int main(void) { >> return 0; >> } >> >> Visit the file over SSHFS: >> >> $ emacs -Q /sshfs:localhost:/tmp/a.c >> >> Now, outside of Emacs, append something to the file: >> >> $ echo aaaaa >> /tmp/a.c >> >> Immediately after that, back in Emacs, hit C-x x g. The new content >> isn't there. Only after reverting the buffer a second time it appears. >> First I thought this was a timing/cache coherency issue, but even >> waiting for 10 seconds doesn't fix it in most cases. Somewhat >> surprisingly, switching to a different buffer in between appears to make >> the problem go away (in some cases at least). > > Looks like you are plagued by caching. revert-buffer reverts a file > only, if it is modified on disk. Tramps caches file attributes by > default for 10 seconds (see remote-file-name-inhibit-cache). Set this > value to t in order to test, whether it makes a difference. However, you > have said you did wait for 10 seconds, so maybe this isn't the reason. > > Another cache might come from sshfs itself. Tramp calls sshfs like > "sshfs localhost:/ /tmp/tramp.sshfs.localhost -C -o idmap=user,reconnect". > See tramp-mount-args settings in tramp-sshfs.el, line 33-34. You might > try to add other options, like "-o no_readahead" or "-o sync_readdir", > see sshfs(1). Don't forget to unmount the sshfs mount point, before you > start a new Emacs session with changed options. The appended patch fixes the problem for me. Since it disables the directory cache of sshfs, there might be performance penalties. Could you, pls, check how it behaves for you? Shall we enable this by default? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment *** /tmp/ediffSUoOdM 2022-03-10 14:04:09.484978898 +0100 --- /home/albinus/src/tramp/lisp/tramp-sshfs.el 2022-03-10 14:01:22.869415240 +0100 *************** *** 51,56 **** --- 51,57 ---- (add-to-list 'tramp-methods `(,tramp-sshfs-method (tramp-mount-args (("-C") ("-p" "%p") + ("-o" "dir_cache=no") ("-o" "transform_symlinks") ("-o" "idmap=user,reconnect"))) ;; These are for remote processes. --=-=-=--