From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#55161: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 17:26:47 +0200 Message-ID: <87a6c56xfs.fsf_-_@bernoul.li> References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: dick , 55161-done@debbugs.gnu.org, Lars Ingebrigtsen , 55149@debbugs.gnu.org, 55149-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 17:35:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk6Ar-000118-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 17:35:21 +0200 Original-Received: from localhost ([::1]:58322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk6Aq-0004Xs-JX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 11:35:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk62p-00015z-GY for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 11:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk62p-0005sk-7i for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 11:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk62p-0004nJ-5R for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 11:27:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 15:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55161-done@debbugs.gnu.org id=D55161.165115961418391 (code D ref 55161); Thu, 28 Apr 2022 15:27:03 +0000 Original-Received: (at 55161-done) by debbugs.gnu.org; 28 Apr 2022 15:26:54 +0000 Original-Received: from localhost ([127.0.0.1]:49640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk62f-0004mU-UG for submit@debbugs.gnu.org; Thu, 28 Apr 2022 11:26:54 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:51072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk62c-0004m4-Fw; Thu, 28 Apr 2022 11:26:51 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 482F4168ED; Thu, 28 Apr 2022 17:26:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:user-agent:message-id :in-reply-to:date:date:references:subject:subject:from:from :received:received; s=sel2011a; t=1651159608; bh=kW292XzJHZczv7p +7CjAKBPvS4qYXAg1Ez8wwqqYLcE=; b=0UhToJpG5GPbgGMfh6l5dYZXq9+QWiu XKXehPQdVmEqDxiFOtP8PPvM8yQQ24ci5bikLRCEyvAxF1sj87mtJOCS1gWH9o2Q QGPsWBDzLDaoMT0ZE89vJCFOdXcQnEZFDRtiXsR/RWI5G7T11d0O0bEDKL3aldIT PHq9ZMJoyNRk= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id CcujSibDbSdD; Thu, 28 Apr 2022 17:26:48 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 13117168F2; Thu, 28 Apr 2022 17:26:48 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Thu, 28 Apr 2022 09:42:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230887 Archived-At: Stefan Monnier writes: > Lars Ingebrigtsen [2022-04-28 12:23:04] wrote: >> dick writes: >> >>> - (:after (apply cdr r) (apply car r)) >>> + (:after (prog1 (apply cdr r) (apply car r))) >> >> I guess this is the same as bug#55149, so I've merged the reports. >> >> Apparently, returning the value of the :after function is what's >> documented to happen (and is what the trunk does now), but it didn't >> use to do that, so it's breaking advice that relies on the old >> behaviour, if I understand 55149 correctly. >> Stefan? > > Yes, I implemented the new code from the doc (since the old code was > written in the form of an "undecipherable" bytecode string), but the doc > was wrong. It's now fixed. At least add-function's docstring did contain the (prog1 ...) until 92e49944a39ce6372a80430f65913c4c8b531677 started to generate the docstring. -`:after' (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) - ... +<<>> So we are not restoring an old bug and changing the docstring to describe the restored behavior instead of the intended but not actually implemented behavior. We unintentionally briefly changed the behavior *as well as* the documentation and have now restored both to what we had before.