From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#55706: 29.0.50; files test fails about 20% of the time Date: Wed, 01 Jun 2022 18:41:28 +0200 Message-ID: <87a6awuyiv.fsf@gmx.de> References: <87ee0cz9d9.fsf@gnus.org> <878rqjvuci.fsf@gmx.de> <877d62an8e.fsf@gnus.org> <87zgiyuir1.fsf@gmx.de> <87mtex5zyz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26537"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55706@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 01 18:42:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwRQN-0006gk-82 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jun 2022 18:42:23 +0200 Original-Received: from localhost ([::1]:51812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwRQK-0000gB-Q8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jun 2022 12:42:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwRQ2-0000fm-HE for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2022 12:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwRQ2-00012Z-7H for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2022 12:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwRQ2-0007WG-2j for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2022 12:42:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ee0cz9d9.fsf@gnus.org> Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Jun 2022 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55706 X-GNU-PR-Package: emacs Original-Received: via spool by 55706-submit@debbugs.gnu.org id=B55706.165410169928875 (code B ref 55706); Wed, 01 Jun 2022 16:42:02 +0000 Original-Received: (at 55706) by debbugs.gnu.org; 1 Jun 2022 16:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:51728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwRPe-0007Vf-Pr for submit@debbugs.gnu.org; Wed, 01 Jun 2022 12:41:39 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:45881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwRPc-0007VM-Ky for 55706@debbugs.gnu.org; Wed, 01 Jun 2022 12:41:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654101690; bh=+qpLEYebolHIvoW+ptx1Wsaa2xc8JwLWYZfvU6iv5Gg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=Wfx0le0SqwGhR0PXy0Ow+93/3cajXsFXMwH9hMIfBxGllfHgVpKF+J6lrB2mqTCCF nmdDHqjHXskSR6HKDK82reVc9UMv0xc0DGAL1fF89PmWeGr6YnkeV2mvSzwY4o7nLL Z+307YOuXMDLbmR/0eeQuXgNJ8gBTxLB+wv40Vmg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.125.156]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdefJ-1nMpbv1MDB-00Zcc2; Wed, 01 Jun 2022 18:41:30 +0200 X-Provags-ID: V03:K1:meWzQVklSuosH41bf8YjKkLbX5fjlH73P1n+0C6leChI2CuTp1I 8fGvmOhsOyIq41Vvc7Ve0Gg3v1dGqag/rU1mjrycLGUQIJKW9q7H/8AZM5oy6CHO0VwTH3n WML+dYjlv3nndt/uxv1GivB1tWN+KsCNA+yyFa/NRvxbZPE9bGbtQJ7IWTxPkMyKqUZvS+p Zwd5asHBzfMVgPDInD8rg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Pmzz/RjI/VA=:H3zE9x8DagsrgcVxITF9Ay m8+CkvisPnEqIh793JnRmOYhQGkvAqGOHsEJWpjHJCj+QaZrb9bi6jHWL1eSl/K+foaMyWpCf xYlLw6fvr6YGmVfyzrplB/61Y2SiN67YW8DpP6ZrZujPxcnEu9pHYwbq1qsGxBBmSYXRYKKbl caCa0mlCd0TmnvKEc+0LTdhMsI+vpdtoXnozl3xYd9fbNglZ4pXQr+Rm0+K1imrEK7Ul+K+IM YMYNfNadsJE+n9msIkRl7MoLu3bEllttV4zqos/9W5uKaSkd/fk3fyNZ7i2YHN+dgH30YplaP UwKZK9G0Ztcqyt+AENNPTrQIiKLQR0krOptK89weDhHOmCphbUAUWT+rgO02Lfm47HPK7e2QR ee1qJJiDoHlSqGlND4gFSYnZuN77Lhd1AiJQd2AW72TttGfNsAHw6eeFpTDBi8ObxQ0YLma3n JSDINygpOvt9jfvH/HVRCHFduQCTJ5U4f6rYoI5RjshJbo//ANaWdQBa46/gdAo/jR36lIYBL CYGgjK9fYs+3brMTor2IxlfRAiW6DgtmzxWkAVTy7cmr3hVyx239zSU+yx4xqDjS6zg/DAIoB hlYNQuoWgxQXXIDlrXQKQh2v4x2SdrH2rQcu18eZb3aMd2IRZ7IAmtJkGSABvRWrh3fzB8ssG Ym7IiOdy4gQu9NBaLXuQ2AZE9EgtDfwXIs23bgTWBtWD2eQokcGcylXJqtsncRr/C0SERgMP6 uFz/pNrJYU5JXUkrpsYj7lqWpq47k6XFK/SSIt+bWkLAIjG4ST9dHhwtOrl1JxX142x7H1cl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233500 Archived-At: Lars Ingebrigtsen writes: Hi Lars, >> I have less cores in my laptop, so I have applied your code with -j8. It >> failed exactly one time. Not bad, so I'm able to reproduce it. > > I was beginning to wonder whether it was just a problem on my build > machine -- I couldn't reproduce it at all on my laptop (but the laptop > is really slow compared to the build machine). Finally, I could catch it. file-in-directory-p calls at the very end (file-equal-p root dir), which is (file-equal-p "/tmp/" "/tmp/") in our test case. In file-equal-p, the file attributes of file1 and file2 are compared via equal, which means in the failing test --8<---------------cut here---------------start------------->8--- (equal '(t 31 0 0 (25238 27804 344363 628000) (25238 27804 371363 598000) (25238 27804 371363 598000) 820 drwxrwxrwt t 1 37) '(t 31 0 0 (25238 27804 344363 628000) (25238 27804 372363 597000) (25238 27804 372363 597000) 800 drwxrwxrwt t 1 37) --8<---------------cut here---------------end--------------->8--- As you can see, the file attributes of "/tmp" are not equal. This is, because between the first and second call of file-attributes, "/tmp" has been changed due to the other test jobs running in parallel. I've fixed this by creating a subdirectory of "/tmp", using it as temporary-file-directory. Pushed to master. Could you, pls, check whether this works also on your build machine with -j64? For me it works w/o any problem, even with an iteration of 100 over "make -j8 check". Best regards, Michael.