From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55779: 29.0.50; child frame Date: Sun, 05 Jun 2022 10:54:53 +0800 Message-ID: <87a6ar251e.fsf@yahoo.com> References: <87wndybdo1.fsf@drshapeless.com> <87leue59fd.fsf@yahoo.com> <87ee06vtds.fsf@drshapeless.com> <87ee063piv.fsf@yahoo.com> <875ylhx0cb.fsf@drshapeless.com> <878rqd44ax.fsf@yahoo.com> <87y1yd2h90.fsf@yahoo.com> <87wndwvdxs.fsf@drshapeless.com> <87leuc3a0x.fsf@yahoo.com> <87o7z8wf5j.fsf@drshapeless.com> <87ilpg0w97.fsf@yahoo.com> <87k09vdiqp.fsf@drshapeless.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 55779@debbugs.gnu.org To: drshapeless Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 05 04:56:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxgR6-0000sM-6w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 04:56:16 +0200 Original-Received: from localhost ([::1]:39268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxgR4-0004Bh-JW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jun 2022 22:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxgQs-0004BY-SE for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2022 22:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxgQr-0000kj-N1 for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2022 22:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxgQr-0005OH-Jn for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2022 22:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2022 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55779 X-GNU-PR-Package: emacs Original-Received: via spool by 55779-submit@debbugs.gnu.org id=B55779.165439771620647 (code B ref 55779); Sun, 05 Jun 2022 02:56:01 +0000 Original-Received: (at 55779) by debbugs.gnu.org; 5 Jun 2022 02:55:16 +0000 Original-Received: from localhost ([127.0.0.1]:59865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxgQ8-0005Mx-BO for submit@debbugs.gnu.org; Sat, 04 Jun 2022 22:55:16 -0400 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:37778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxgQ3-0005MY-D7 for 55779@debbugs.gnu.org; Sat, 04 Jun 2022 22:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1654397704; bh=94erMgxg1x+RuH5Q2PF51yqN4OmWz1G0EIRPNm/8TAc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=AdVzwS++cj3rSCVLzu7y0CM0toizH8IoFvMEMWRrTJY/7s9cutGRZLlRRFbstj+ddWRX0zGwGhbLY9ABWcoLNCDx2OcwAcTNunxIFdl+IH9g0MY9A8ju64bhWvZw2+NZsPEzO4yakqtDKvWDeOLTWhbRiU4DSSozDUJPYB4SGQ14RnZCi9ux+9Y+7vmco6AuQs7IOcDGUeBV/elDBDdl46q2vDgqKwheTGwxS9bcrO0dV6aTxLSSp2wyZeYDlqWHtMfqLQ/Fr37CH5mZzXqUtbyJ6gd0HnZk0mHf3iBIs7poKf2emQeOL23tOKzjqHRRj8O/dFc7xZgH+dQ6q60Nlg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1654397704; bh=VNtjn0uvnNGu31YFbt3JRaZ08H962MIJVZjRFppkG/r=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=K8XRRCPMgBgx+LUhI5nkrMgOXaEKI7rKZsEBEzEDLr+y1zYWxBd/uDMZ7JEuKPyiqsTNcOs3CTmZO3rClbU6/WOaNGFyUyfGRV+Z7DsIdfmjLMMBhlwYGnQEfZijUyBbGLIy7fZzKiYRsgHa8u3cmdk35QCf3PxffxIRGqmQqM8CskC7wDZnzSOVZHsg1RI0vjWDtJjYohiwSCIO3Rs63+dEQatN5j1YzFySpQIAhjSIh7QosIZJhdYoe0b341f41obT2EmLZSH1VIDaKGytpi0qvyE0Cfsh1BtzBncSpYtFvos6+pV2pykjvJNllHh+zWIuyRwjOAzRYPcb4nyw7Q== X-YMail-OSG: D.aaZFEVM1mDEF5akxVWShAfmh3jNJnAAk6HTljkqyhsBp_5fAI6QQGs3zznKwx Zwb.E626AwbEYvSAf67XSSGT7PJQjhyOzALTxwHYotr.1LEvogrqKBrL46AuEYhnj.3VYSR4F7ON NIq4ZUPRS3R_aXVD2ww2li4XeLPHDWTxbXV4y6oE6JLxWnSIIgqqWj1MKIl.wzH9JhvooBwdq.fH AUWQMi3gzMC1vrowlpqkuwDyzw1gn0ls0d1_9XDdsxei0SvWdvBPDTj7zA6bVVI_8b8hvMe7edr. cpIYJ5He_es8hsXjX1CtmRbptg0C0URUnk4yKJIgeI5G9rhQsGvGf_bcjBrrsX543rCaDVGMyCh_ UB_IunYJd7SPASOyW4yKiEJmIrLJAyYJLwSprUlrpGOlSDuSSKLv.pXw7sV_GySxxL1tmbAZidAy IsMy7JHuj6bHZ_c6pNCpYi4ga40z3.73GxO3MKa_YJPaWhZHrDljLPsfv7Oa1slmtVtKVCa9Y709 uUqWD.L4o1IKLjB._FY7qw41DDcsKNXL5E8r1vrLCk8fohjI2winmRm0wpOy3cEa7Mzho_L6ZXHH vmVW29q09ZGGQlJnUwwG1DeFUlNrhP6dUTv4iNTPDuA0LxSxiKxGlKP8zItX.bRy_omBu1.6IXk3 o6uKXBSaQO9RYSWRLWEPktBqb47nbgD2S0GQaKv2e7Wsd1ZyufpwVky5ZjLmdB64OC2BEcpBkRpE CS0bYC9z1iqJd1.vkRgcLaPK0bOBXbMHRax01ItxVhZGJPa4OiNyz.H9vr61LOExMXO0xS4X6hwF NA2X2p..kH6LQVHo_3cCNa4yttthnBhg88F4DMIDGF X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sun, 5 Jun 2022 02:55:04 +0000 Original-Received: by hermes--canary-production-sg3-5f7658c994-rpd7c (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 142f9ca236430c0f65ebd20d8b73a2a7; Sun, 05 Jun 2022 02:54:58 +0000 (UTC) In-Reply-To: <87k09vdiqp.fsf@drshapeless.com> (drshapeless's message of "Sun, 05 Jun 2022 09:03:26 +0800") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233684 Archived-At: drshapeless writes: > If I comment this part out, even at the lastest master commit, the issue > is solved. I could say these few lines of code is the root of the bug. > > I have no idea what is going on though. Thanks. I didn't quite figure that out either. Does this also fix the problem? diff --git a/src/xterm.c b/src/xterm.c index 2bf37e94d6..7f9d4c6ff6 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -4349,11 +4349,16 @@ x_update_opaque_region (struct frame *f, XEvent *configure) (unsigned char *) &opaque_region, 4); else { - object_class = G_OBJECT_GET_CLASS (FRAME_GTK_OUTER_WIDGET (f)); - class = GTK_WIDGET_CLASS (object_class); + /* This causes child frames to not update correctly for an + unknown reason. (bug#55779) */ + if (!FRAME_PARENT_FRAME (f)) + { + object_class = G_OBJECT_GET_CLASS (FRAME_GTK_OUTER_WIDGET (f)); + class = GTK_WIDGET_CLASS (object_class); - if (class->style_updated) - class->style_updated (FRAME_GTK_OUTER_WIDGET (f)); + if (class->style_updated) + class->style_updated (FRAME_GTK_OUTER_WIDGET (f)); + } } #endif unblock_input ();