From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: drshapeless <drsl@drshapeless.com>
Cc: 55779@debbugs.gnu.org
Subject: bug#55779: 29.0.50; child frame
Date: Sun, 05 Jun 2022 10:54:53 +0800 [thread overview]
Message-ID: <87a6ar251e.fsf@yahoo.com> (raw)
In-Reply-To: <87k09vdiqp.fsf@drshapeless.com> (drshapeless's message of "Sun, 05 Jun 2022 09:03:26 +0800")
drshapeless <drsl@drshapeless.com> writes:
> If I comment this part out, even at the lastest master commit, the issue
> is solved. I could say these few lines of code is the root of the bug.
>
> I have no idea what is going on though.
Thanks. I didn't quite figure that out either.
Does this also fix the problem?
diff --git a/src/xterm.c b/src/xterm.c
index 2bf37e94d6..7f9d4c6ff6 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -4349,11 +4349,16 @@ x_update_opaque_region (struct frame *f, XEvent *configure)
(unsigned char *) &opaque_region, 4);
else
{
- object_class = G_OBJECT_GET_CLASS (FRAME_GTK_OUTER_WIDGET (f));
- class = GTK_WIDGET_CLASS (object_class);
+ /* This causes child frames to not update correctly for an
+ unknown reason. (bug#55779) */
+ if (!FRAME_PARENT_FRAME (f))
+ {
+ object_class = G_OBJECT_GET_CLASS (FRAME_GTK_OUTER_WIDGET (f));
+ class = GTK_WIDGET_CLASS (object_class);
- if (class->style_updated)
- class->style_updated (FRAME_GTK_OUTER_WIDGET (f));
+ if (class->style_updated)
+ class->style_updated (FRAME_GTK_OUTER_WIDGET (f));
+ }
}
#endif
unblock_input ();
next prev parent reply other threads:[~2022-06-05 2:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 3:59 bug#55779: 29.0.50; child frame drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-03 8:19 ` bug#55779: Acknowledgement (29.0.50; child frame) drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-03 10:27 ` bug#55779: 29.0.50; child frame Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87ee06vtds.fsf@drshapeless.com>
[not found] ` <87ee063piv.fsf@yahoo.com>
2022-06-03 14:56 ` drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 1:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 3:10 ` drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 4:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 11:57 ` drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 12:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-04 16:46 ` drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 0:49 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 1:03 ` drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 2:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-06-05 3:55 ` drshapeless via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-05 5:04 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ar251e.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=55779@debbugs.gnu.org \
--cc=drsl@drshapeless.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).