From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57102: 29.0.50; Peculiar file-name-split edge case Date: Wed, 10 Aug 2022 08:24:52 +0000 Message-ID: <87a68cwlnv.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36813"; mail-complaints-to="usenet@ciao.gmane.io" To: 57102@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 10 10:26:59 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLh3K-0009L9-Ai for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 10:26:58 +0200 Original-Received: from localhost ([::1]:47336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLh3J-0005cY-7H for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 04:26:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLh2Q-00050Y-Ra for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLh2Q-0001sr-DG for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLh2Q-0007UX-8k for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2022 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57102 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166011991328737 (code B ref -1); Wed, 10 Aug 2022 08:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Aug 2022 08:25:13 +0000 Original-Received: from localhost ([127.0.0.1]:45987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLh1c-0007TQ-7Z for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:25:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:33466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLh1Z-0007TF-2o for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:25:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLh1X-0004fm-I8 for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:25:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:55679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLh1Q-0001dH-Ac for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:25:04 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 115DB240101 for ; Wed, 10 Aug 2022 10:24:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1660119898; bh=NRvX1IOYxOz05stMznt7Y3gKONwgsDx+g6z3OKnXIzs=; h=From:To:Subject:Autocrypt:Date:From; b=TyaEqo7TKFSm//Q8DZ0tmdIJo4SYW94AD+MMKa5HqlXTF7SlyZ+3jpKA+F17lXjvz 5PeDWytOIs97DD31THtkr0798FJwMAK40LoMimQ6CkMN7VMV++XFDyjZc4pDrAFSLm VAclDHWA1R8Xasdk26cBx1x6Q82JoseqNchk+8ylCSpCRDNj+YWpeq6MzcrUKSA4tM ThgbVTqTGD/i40pSgzF09O6hDeuGv/35Fmrt0iNQesQpg5AinVmgFLq/mBWEWR0Ndx m4E7I/YleTmg+VFpqdN8yD49RXQSMXIefOtPmKfuRmZ6Okk6r7rxtWvaMfxyzC+fXT 6oz6iQbp74wPQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4M2jfd2mnQz9rxd for ; Wed, 10 Aug 2022 10:24:57 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239253 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I am not sure if this is intentional, but the new `file-name-split' is a bit unintuitive in this edge-case: (file-name-split "/") =E2=86=92 ("" "" "") while (file-name-split "/a") =E2=86=92 ("" "a") (file-name-split "a/") =E2=86=92 ("a" "") (file-name-split "a/b") =E2=86=92 ("a" "b") another few peculiar cases might be (file-name-split "//") =E2=86=92 ("/" "" "") (file-name-split "///") =E2=86=92 ("" "" "") (file-name-split "////") =E2=86=92 ("" "" "") as I'd expect '/' (in the first case) to never be part of a file name (at least on a *nix system). This all appears to happen only if there is no actual file name to be found: (file-name-split "a/") =E2=86=92 ("a" "") (file-name-split "a//") =E2=86=92 ("a" "") (file-name-split "a///") =E2=86=92 ("a" "") One simple solution might just be to remove all empty strings from the return value of `file-name-split', as to my knowledge empty file names are now allowed (?): --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/files.el b/lisp/files.el index 65f9039b33..c5817be8da 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -5170,7 +5170,7 @@ file-name-split (substring dir 0 -1)) components) (setq filename nil)))) - components)) + (delq "" components))) (defun file-parent-directory (filename) "Return the directory name of the parent directory of FILENAME. --=-=-= Content-Type: text/plain That should take care of all the inconsistencies I see here, and it would also preserve the usual intuition that "path///to//file" designates the same path as "path/to/file". In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-08-01 built on rhea Repository revision: 47f1cae83c269ea43d6b208e055ce536c017856f Repository branch: feature/package+vc System Description: Fedora Linux 36 (Workstation Edition) Configured using: 'configure --with-pgtk --with-native-compilation --with-imagemagick' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t shell-dirtrack-mode: t outline-minor-mode: t flymake-mode: t flyspell-mode: t repeat-mode: t diff-hl-flydiff-mode: t diff-hl-mode: t winner-mode: t windmove-mode: t corfu-history-mode: t corfu-mode: t vertico-multiform-mode: t vertico-mode: t electric-pair-mode: t recentf-mode: t save-place-mode: t savehist-mode: t xterm-mouse-mode: t pixel-scroll-precision-mode: t pixel-scroll-mode: t display-time-mode: t display-battery-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t auto-save-visited-mode: t Load-path shadows: /home/philip/.config/emacs/elpa/transient-0.3.7/transient hides /home/philip/Source/emacs/lisp/transient ~/.config/emacs/site-lisp/autoload hides /home/philip/Source/emacs/lisp/emacs-lisp/autoload /home/philip/Source/emacs/lisp/ps-def hides /home/philip/Source/emacs/lisp/obsolete/ps-def Features: (shadow emacsbug flymake-cc cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs ert loadhist mode-local help-at-pt emacs-news-mode magit-extras dictionary dictionary-connection qp timezone flow-fill mailalias smtpmail autocrypt-message ecomplete ietf-drums-date sort smiley gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-bcklg nnfolder modus-vivendi-theme ibuffer ibuffer-loaddefs compat-27 compat-26 compat-25 compat-24 cus-start hyperspec vertico-buffer make-mode locate doctor files-x shell-command+ cl-print edebug debug backtrace consult-vertico consult-icomplete consult compat-28 magit-bookmark bookmark macrostep compat-macs avy gnus-async gnus-ml disp-table autocrypt-gnus autocrypt utf-7 nndraft nnmh epa-file gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache whitespace shortdoc pulse color bug-reference grep xref copyright time-stamp face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode git-commit log-edit add-log magit-core magit-autorevert autorevert magit-margin magit-transient magit-process with-editor shell server magit-mode transient edmacro kmacro magit-git magit-section magit-utils crm dash dired-aux gnus-dired vc-hg vc-git vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs sh-script smie executable vc-backup log-view pcvs-util buffer-env compat org-element avl-tree generator ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr pixel-fill kinsoku url-file url-dired svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win ol-docview doc-view filenotify jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 ol org-keys oc org-compat advice org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs char-fold misearch multi-isearch mm-archive message yank-media rfc822 mml mml-sec epa mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mule-util gnutls network-stream url-cache url-http url-auth mail-parse rfc2231 url-gw nsm puny display-line-numbers finder-inf vertico-directory orderless vertico-flat noutline outline checkdoc flymake-proc flymake thingatpt flyspell ispell comp comp-cstr warnings auth-source-pass repeat project dired-x sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util time-date mail-utils range mm-util mail-prsvr diff-hl-flydiff diff diff-hl vc-dir ewoc vc dired dired-loaddefs vc-dispatcher diff-mode hippie-exp winner windmove corfu-history corfu vertico-multiform vertico elec-pair recentf tree-widget saveplace savehist xt-mouse modus-operandi-theme modus-themes cus-edit pp icons wid-edit format-spec pixel-scroll cua-base icomplete time battery dbus xml cus-load setup site-lisp compile text-property-search comint ansi-color easy-mmode autoload loaddefs-gen lisp-mnt coterm-autoloads embark-autoloads magit-autoloads vertico-autoloads buffer-env-autoloads geiser-chibi-autoloads consult-autoloads compat-autoloads crdt-autoloads corfu-autoloads slime-autoloads geiser-impl help-fns radix-tree geiser-custom geiser-base ring transient-autoloads info tex-site package let-alist derived rx pcase cl-extra help-mode browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json map byte-opt gv bytecomp byte-compile cconv url-vars epg rfc6068 epg-config subr-x cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 1305290 153382) (symbols 48 47185 40) (strings 32 229531 23057) (string-bytes 1 7942713) (vectors 16 115746) (vector-slots 8 2759557 273441) (floats 8 843 1462) (intervals 56 52420 4538) (buffers 992 64)) --=-=-=--