From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51130: 29.0.50; shell completion fails to complete filenames Date: Mon, 12 Sep 2022 13:22:33 +0200 Message-ID: <87a67496rq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51130@debbugs.gnu.org, Stefan Monnier To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 12 13:54:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXi1G-0003ip-GU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 13:54:30 +0200 Original-Received: from localhost ([::1]:38650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXi1F-0004s6-I5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 07:54:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXhWo-0000W3-S1 for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 07:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXhWo-0000me-F9 for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 07:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXhWo-0007By-AL for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 07:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2022 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51130 X-GNU-PR-Package: emacs Original-Received: via spool by 51130-submit@debbugs.gnu.org id=B51130.166298177227608 (code B ref 51130); Mon, 12 Sep 2022 11:23:02 +0000 Original-Received: (at 51130) by debbugs.gnu.org; 12 Sep 2022 11:22:52 +0000 Original-Received: from localhost ([127.0.0.1]:44357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhWe-0007BE-9x for submit@debbugs.gnu.org; Mon, 12 Sep 2022 07:22:52 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXhWW-0007Ac-7b for 51130@debbugs.gnu.org; Mon, 12 Sep 2022 07:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UGFAbdsjuafKppGScri9nxK8SM15g2Uhwtb4FpuOcgU=; b=Nbmw7R5hDc8zCA0XXZz+6hHH9g 3vrYvMiQiHrPIJThwdKIoN8qH2c5O/6xA0HV09Sg0UM8cjDx4K+wsVlSbgKx6J0lMXMutKW6LVzSK 4XNxkHKkXduiOrzYYLOk0BylnJYlvNkTtsLVi1a8W6vayGzrO3EukG2HtvgOCpGx4Vss=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhWL-0005bb-Vw; Mon, 12 Sep 2022 13:22:36 +0200 In-Reply-To: (Carlos Pita's message of "Mon, 11 Oct 2021 00:08:19 -0300") X-Now-Playing: Django Django's _Django Django (Remaster)_: "Wor" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242243 Archived-At: Carlos Pita writes: > Now, many usual commands like cp don't have a pcomplete handler so they > behave very poorly regarding completion, take for example: > > cp > > this doesn't give me any completion candidate! [...] > In shell.el we have: > > ;; Don't use pcomplete's defaulting mechanism, rely on > ;; shell-dynamic-complete-functions instead. > (setq-local pcomplete-default-completion-function #'ignore) > > So pcomplete is falling back to the ignore (no-op) function. If you > kill the local binding in the shell buffer, then the default of the > default does complete paths. This was possibly added by: commit e17d9003618cef75852a0b88334cea66a5c4b016 Author: Stefan Monnier AuthorDate: Sat Jun 4 09:31:34 2011 -0300 * lisp/shell.el: Require and use pcomplete. (shell-dynamic-complete-functions): Add pcomplete-completions-at-point. (shell-completion-vars): Set pcomplete-default-completion-function. Just leaving pcomplete-default-completion-function alone seems to give better results in shell-mode (after testing very briefly), so I'm not sure why that was added. Perhaps Stefan has some comments; added to the CCs.