From: Augusto Stoffel <arstoffel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: public@protesilaos.com, 57876@debbugs.gnu.org
Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
Date: Sat, 17 Sep 2022 12:56:44 +0200 [thread overview]
Message-ID: <87a66yclqr.fsf@gmail.com> (raw)
In-Reply-To: <83sfkq1gu0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 12:38:15 +0300")
On Sat, 17 Sep 2022 at 12:38, Eli Zaretskii wrote:
>> Cc: Protesilaos Stavrou <public@protesilaos.com>
>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Sat, 17 Sep 2022 10:23:01 +0200
>>
>> Tags: patch
>>
>> Currently, if point is say at the prompt of a comint buffer,
>> pulse-momentary-highlight-one-line doesn't show do anything – or, more
>> precisely, it pulses the zero-length region from prompt end to EOB.
>>
>> Prot: I think you want to apply a similar change in pulsar.el.
>>
>>
>> >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001
>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Sat, 17 Sep 2022 10:17:34 +0200
>> Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
>>
>> * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Act on
>> entire visual line, ignoring fields etc.
>
> Why don't you use beginning/end-of-visual-line?
Because it obeys fields, so if you try to highlight a prompt line in a
comint buffer, only part of the line would be highlighted.
The (only, AFAICT) purpose of pulse-momentary-highlight-one-line is to
locate the cursor, so you want to pulse a little rectangle spanning the
entire width of the window.
next prev parent reply other threads:[~2022-09-17 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 8:23 bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Augusto Stoffel
2022-09-17 9:38 ` Eli Zaretskii
2022-09-17 10:56 ` Augusto Stoffel [this message]
2022-09-17 11:20 ` Eli Zaretskii
2022-09-17 11:31 ` Augusto Stoffel
2022-09-17 11:49 ` Eli Zaretskii
2022-09-18 7:23 ` Protesilaos Stavrou
2022-09-18 11:02 ` Lars Ingebrigtsen
2022-09-18 12:40 ` Eli Zaretskii
2022-09-18 12:45 ` Lars Ingebrigtsen
2022-09-18 12:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a66yclqr.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=57876@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=public@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).