From: Gustavo Barros <gusbrs.2016@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 57856@debbugs.gnu.org
Subject: bug#57856: 28.2; bookmark context strings in encrypted files
Date: Tue, 20 Sep 2022 12:03:45 -0300 [thread overview]
Message-ID: <87a66ucc7a.fsf@gmail.com> (raw)
In-Reply-To: <878rmegkx5.fsf@gmx.de>
Hi Michael,
On Tue, 20 Sep 2022 at 16:49, Michael Albinus <michael.albinus@gmx.de>
wrote:
> I gave it a try. WDYT?
> (Documentation must be added, of course)
If I may, I do have a comment about the defcustom. I think
`bookmark-inhibit-bookmark-functions` is not really a precise name,
since it is not about inhibiting the bookmark itself, but only the
context strings. How about `bookmark-inhibit-context-functions`? On
the same vein, the docstring could be clearer about it. Say:
"List of functions to call before making a bookmark record.
The functions take `buffer-file-name' as argument. If any of
these functions returns non-nil, the bookmark does not record
context strings from the current buffer."
WDYT?
(Either way, thank you!)
Best regards,
Gustavo.
next prev parent reply other threads:[~2022-09-20 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 11:08 bug#57856: 28.2; bookmark context strings in encrypted files Gustavo Barros
2022-09-16 12:07 ` Lars Ingebrigtsen
2022-09-16 12:30 ` Gustavo Barros
2022-09-16 13:01 ` Lars Ingebrigtsen
2022-09-16 13:18 ` Michael Albinus
2022-09-18 10:19 ` Lars Ingebrigtsen
2022-09-18 10:43 ` Michael Albinus
2022-09-19 7:42 ` Lars Ingebrigtsen
2022-09-19 9:00 ` Michael Albinus
2022-09-19 12:03 ` Lars Ingebrigtsen
2022-09-19 12:16 ` Michael Albinus
2022-09-19 12:34 ` Lars Ingebrigtsen
2022-09-19 13:03 ` Michael Albinus
2022-09-19 18:44 ` Lars Ingebrigtsen
2022-09-20 14:49 ` Michael Albinus
2022-09-20 14:53 ` Lars Ingebrigtsen
2022-09-20 15:00 ` Michael Albinus
2022-09-20 15:03 ` Gustavo Barros [this message]
2022-09-20 16:19 ` Michael Albinus
2022-09-19 11:13 ` Gustavo Barros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a66ucc7a.fsf@gmail.com \
--to=gusbrs.2016@gmail.com \
--cc=57856@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).