From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Date: Mon, 26 Sep 2022 17:06:22 +0300 Message-ID: <87a66mdych.fsf@protesilaos.com> References: <87bkr2mhj1.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34145"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Stefan Kangas To: Dmitry Gutov , 58092@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 26 16:18:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocow5-0008kB-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 16:18:17 +0200 Original-Received: from localhost ([::1]:58788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocow0-0005Dc-RD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 10:18:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocolC-00007t-H5 for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 10:07:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocolC-0001j5-96 for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocolB-0000pU-Rh for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642012013159 (code B ref 58092); Mon, 26 Sep 2022 14:07:01 +0000 Original-Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:51292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocoko-0000oq-1A for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:06:41 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:59183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocoki-0000oZ-Pf for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:06:36 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id F2F8B24000C; Mon, 26 Sep 2022 14:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1664201186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N0/kGbAk5KWNSqPmKI+mGx8QvsGIWPuhj0rkqSUFHmw=; b=GQJH/QmwJy/bhR+JACfMjW7Xd9xzHq0eH7DgGmjCMDBXMowykJ8o4VYqf3E0OAsp7YVlae +f0gA0eHNsIqtwW7TIcjeQNPI1vpKMxdzSBGzRMfGQ/zZ1lOnoxVtYmJYwQw9Sg3RCJFXp 0NVEpZXsD4wfED0vuBtSoW+34CQ/L86Alf5+mQM8lxemgIDQ+AIM5iTl7cCHn5foNvKxC+ WtRtRLrSu+498JcBz8t9zkipTeIAdfnanKVf8ht2YfG7Lh+0duTfkDDECYsKogm/VFvsH/ h5taGBADFvfkX/Yxb6MTMFQM93xpYz13rzOq7BDD19qkMAeErF1xwY2m97+ndA== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243661 Archived-At: > From: Dmitry Gutov > Date: Mon, 26 Sep 2022 16:28:56 +0300 > > Hi! > > On 26.09.2022 15:44, Protesilaos Stavrou wrote: >> Dear maintainers, >> >> The attached patch replaces some hardcoded face properties in log-edit >> buffers with a named face. >> >> The named face allows users/themes to customise how this line is styled. >> >> What do you think? > > LGTM, except perhaps call it headers-separator? It's used to separate > all the headers, not just summary. Hello everyone, I made the changes as you suggested and pushed them as commit a386833503. However, I forgot to update the commit message of the patch: it still mentions the old name of the face 'log-edit-summary-separator' instead of 'log-edit-headers-separator'. Sorry for this mistake! Can I revert or amend it? -- Protesilaos Stavrou https://protesilaos.com