From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Thu, 10 Nov 2022 22:30:54 +0000 Message-ID: <87a64y8msh.fsf@gmail.com> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1641"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , dgutov@yandex.ru, felician.nemeth@gmail.com, 58790@debbugs.gnu.org, stefankangas@gmail.com To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 23:30:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otG3s-0000H5-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 23:30:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otG3h-0007jo-3A; Thu, 10 Nov 2022 17:30:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otG3e-0007iv-On for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 17:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otG3e-0003vd-Fh for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 17:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otG3e-0005nL-AP for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 17:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166811938922231 (code B ref 58790); Thu, 10 Nov 2022 22:30:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 10 Nov 2022 22:29:49 +0000 Original-Received: from localhost ([127.0.0.1]:44583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otG3R-0005mU-Ct for submit@debbugs.gnu.org; Thu, 10 Nov 2022 17:29:49 -0500 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:43593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otG3N-0005mF-PP for 58790@debbugs.gnu.org; Thu, 10 Nov 2022 17:29:48 -0500 Original-Received: by mail-wm1-f41.google.com with SMTP id a11-20020a05600c2d4b00b003cf6f5fd9f1so2085782wmg.2 for <58790@debbugs.gnu.org>; Thu, 10 Nov 2022 14:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fSoUytEMHxXZueMzxrLqmcJa8ncKWKBYyORO2X93hsQ=; b=P71lr/3SmLk8qKzNml5Uqtnszl/q2L6QpqL6QPobNAf+5hjon8BU774kqeg3AtVM0P eZrhNWuTg57TcLM+q9OFJ47T4b8r2sws2F8KLFE8mWVu5tuJrCzHTaKOyQMrBMnl+Pcm CLQO4Tl2KB8SIh9KVuDYvgQM9W3WPoccO1OjImaMtN87ia4OYUwcdUUzu4Pc3ri62LAU xvmzfSbJvBQP+wTiQW7kgnRK7opToddTUtu3VhoCWiHh13VxUifQrBSMK+brMBoB/AMI E3S9iIB/Ej4tZA2OScUli5rkJ88Ps+j9Goe+j5Fb8GTPCQ0aFTwYn/vt+R6WwzVUXL9i pVZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fSoUytEMHxXZueMzxrLqmcJa8ncKWKBYyORO2X93hsQ=; b=D+9RYZd2yQxev32kS61gQ8oAsLodAKj0Ttr2tV+jkMBgMWeFmF9+wpJsitebzb38KC ooXvbgqfS6OQwqg6+QWfNNmMrdxjKqLZ5pEWMtqLqN/v9reeRSM4HXezBJ+sBTbCXzoN nG1Fbtl4dFZjfzev9v5P1dz/seJnsodYKq3vhNO3pireFwXz9yxMXCqEEOiqQsgyrM7t mgHGb4X3PYi3Wzx2bD841BdmichZKMLjnv4prmJNSXHdUloCWkKb16P+Ghoikg/r8HWT zl+BkQsPCRmucQoZCAHiHE1wHD9WarbVBnf9eWpDGS3ajJ8KrHjfX7GwJMv6CcrbmqI8 bqcg== X-Gm-Message-State: ACrzQf0wvAY9X7KL3WI482rsy5NorcEq2whUHsYoLssEH2f8vVRgROmP zwKoYjshRxIo5LI/BNr7/Hw= X-Google-Smtp-Source: AMsMyM7e87btaYezOKU6wvY6ytIrDaWGmZuilMdbVL2Bm4r8F1nHgCO0ekowmMi7i4aK0S37k/k1SQ== X-Received: by 2002:a05:600c:6023:b0:3cf:7dc1:e08e with SMTP id az35-20020a05600c602300b003cf7dc1e08emr35308880wmb.154.1668119379641; Thu, 10 Nov 2022 14:29:39 -0800 (PST) Original-Received: from krug (87-196-81-1.net.novis.pt. [87.196.81.1]) by smtp.gmail.com with ESMTPSA id az40-20020a05600c602800b003b492753826sm794733wmb.43.2022.11.10.14.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 14:29:39 -0800 (PST) In-Reply-To: <87fseqtpiu.fsf@dfreeman.email> (Danny Freeman's message of "Thu, 10 Nov 2022 17:22:15 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247557 Archived-At: Danny Freeman writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I agree on the two comments about the ChangeLog style entries and the >> spacing.=20=20 >> >> But when dealing with eglot.el, which I am the prime maintainer of,=20 >> I really prefer to see design described in the commit message where the= =20 >> design was introduced. It plays very well with vc-region-history. >> >> So Danny, if you don't mind, please revert that part.=20=20 >> >> Jo=C3=A3o > > Yall all really taking me for a ride on this lol. Sorry. The Emacs commit message format is a bit of work in the beginning but it pays off in the end. I will make minor adjustment to your patches and push them now. > In reviewing the comments over and over I've made a modification to the > second patch involving the warning message. Instead of using an > arbitrary symbol I realized that the function `find-file-name-handler' > works when a nil value for the second argument (operation). OK, I will look at this part, too. Jo=C3=A3o