From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#60854: Adjust icons shown with warnings Date: Wed, 18 Jan 2023 11:30:38 +0100 Message-ID: <87a62gb0dt.fsf@gmail.com> References: <874jsog5x0.fsf@gmail.com> <346de561-ac0f-017b-832a-036ff3eadb99@gmail.com> <877cxkqqs8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25465"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Pedro Andres Aranda Gutierrez , 60854@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 18 11:31:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pI5jV-0006RT-Fn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Jan 2023 11:31:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI5jD-0001Jx-5m; Wed, 18 Jan 2023 05:31:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI5ik-0001GJ-TS for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 05:31:33 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pI5ig-0002d0-4n for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 05:31:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pI5if-0004u4-V3 for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 05:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jan 2023 10:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60854 X-GNU-PR-Package: emacs Original-Received: via spool by 60854-submit@debbugs.gnu.org id=B60854.167403785018830 (code B ref 60854); Wed, 18 Jan 2023 10:31:01 +0000 Original-Received: (at 60854) by debbugs.gnu.org; 18 Jan 2023 10:30:50 +0000 Original-Received: from localhost ([127.0.0.1]:39274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI5iT-0004te-UD for submit@debbugs.gnu.org; Wed, 18 Jan 2023 05:30:50 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:42729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI5iQ-0004tP-At for 60854@debbugs.gnu.org; Wed, 18 Jan 2023 05:30:48 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id k8so18944556wrc.9 for <60854@debbugs.gnu.org>; Wed, 18 Jan 2023 02:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hcqJmyAoyd8JlKZwbsckDdI3xE0LykoM+mzGm1cyxY4=; b=I6H87vqb8dZ+ZqgQJtd3Rh84zB1ZHUOWmPKxakB3uSEYr53541OFHZUp866/icQSYJ uFtjYj1eeuICLxRg72Y7UTmapKPqqX/FGdOCUQpTi51Vovu44uhPZfimPh9DVPFbDm9l hqW34UmHAduK+ECqywefN34hhNaZoh1BTGmuKoZD5DD+pYEWaHjLHjhoJfzpzIaKSbmO e5+8Fh6EC1413C2KgGTgSnUUMD7vWmTfk85CJiY5riIjajbpB6rOkdSAtIKMfJchp4cW etkq23BZIjjLnClR4vHRZOCNTcUJLAUmspsAAjmIpg2zFp4TEl4a8akCGQpHLUCUoNi+ Vz+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hcqJmyAoyd8JlKZwbsckDdI3xE0LykoM+mzGm1cyxY4=; b=xqSukyBfJpkrBeroWlHPDXW7e+m4pO8J13ji9XJQ370D0BLpenAG+ibk9dz4fcRjm3 HWbkABG/CcsDCdS0iSCkXwsB8Gk72/NrT7rxG2xUWXypvPN5E6SnfMG5F5Kk39wm/iY4 1R8d7ku2NB6aR0vjQatmpPh4Erasvp//pureHEJINlfj7+F4Sc8hmwpGzVE7bJgc6CVW 0NS+0BZhTFjJyfNff0r/rVdAigK2Zbxs9msPv5RSpdYTw4NrWhaOorGBZE96wNUPlYNG oV3knOuR+x44u6S6ekRFwrPtGNNAwIrgRW17CNeQpsvl7vwunnQVP5CT6PXIjadOBJA7 zhpQ== X-Gm-Message-State: AFqh2krs4E3I7hZjKcfuv1qPAvIrbxQ1akjtVzQn2F7202RNFOLMv+5+ aBm8sNw/abeBmxaMF5enA+c= X-Google-Smtp-Source: AMrXdXv4E8BjAkj4RG91Qnj9xWENIiBRRWnSn1BRVdV82ZJS5Nc9doWgX/ZIWZ58og0/oK6LUz4ZKQ== X-Received: by 2002:adf:cf10:0:b0:276:d6ba:4b91 with SMTP id o16-20020adfcf10000000b00276d6ba4b91mr12581763wrj.47.1674037840106; Wed, 18 Jan 2023 02:30:40 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n13-20020a5d67cd000000b002bdcce37d31sm19990554wrw.99.2023.01.18.02.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 02:30:39 -0800 (PST) In-Reply-To: <877cxkqqs8.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Wed, 18 Jan 2023 07:51:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253616 Archived-At: >>>>> On Wed, 18 Jan 2023 07:51:19 +0100, K=C3=A9vin Le Gouguec said: K=C3=A9vin> Jim Porter writes: >> On 1/17/2023 2:19 PM, K=C3=A9vin Le Gouguec wrote: >>> Jim Porter writes: >>>> Perhaps a bit better would be =F0=9F=9A=AB, whose official name is= apparently "No Entry >>>> Sign", even though the slashed circle visual usually just means "N= o ____", >>>> e.g. "No Smoking". Hence, some sources call it the Prohibited emoj= i. >>> (My =C2=A22: wouldn't a cross mark (=E2=9D=8C) also work to convey = the idea of >>> "suppressing" something?) >>=20 >> That would work too. I still like turning this into a toggle button = where the >> icon shows the current state (i.e. is it an active warning - =E2=9A= =A0=EF=B8=8F - or has it been >> suppressed - =E2=9A=AC). But changing to =F0=9F=9A=AB or =E2=9D=8C w= ould be single-character patches, >> which is nice too. K=C3=A9vin> Sure, the toggle sounds like a nice idea regardless, since = IIUC right K=C3=A9vin> now a user has to go through Customize to take warnings off= either K=C3=A9vin> warning-suppress-*types. K=C3=A9vin> (Sorry for the idle musing, this is the first time I look a= t what knobs K=C3=A9vin> warnings.el lets the user tweak. K=C3=A9vin> As things stand, if a user doesn't want to completely igno= re a warning, K=C3=A9vin> their only choices seem to be "pop *Warnings*" or "meh, tu= ck it in K=C3=A9vin> *Warnings* but don't pop; hopefully I'll remember to check= that buffer K=C3=A9vin> someday", is that correct? Yes K=C3=A9vin> Might be nice to have further options for "suppression", e= .g.=E2=80=A6 K=C3=A9vin> "don't pop the *Warnings* buffer, but display in echo area= ", or K=C3=A9vin> "=E2=80=A6 but add a modeli= ne indicator" K=C3=A9vin> =E2=80=A6 but that's its own feature request) Sure. Just don=CA=BCt turn that on by default :-) >>> The new icons.el that comes with Emacs 29 would be a prime candidat= e for >>> implementing this, right? It has the advantage of giving the user = some >>> degree of control via icon-preference. >>=20 >> Yup, the icon we have today is implemented via icons.el: >>=20 >> =EF=BB=BF (define-icon warnings-suppress button >> '((emoji "=E2=9B=94") >> (symbol " =E2=96=A0 ") >> (text " stop ")) >> "Suppress warnings." >> :version "29.1" >> :help-echo "Click to suppress this warning type") K=C3=A9vin> (Ah, great, so we're only missing an 'image entry for that = one. Just a K=C3=A9vin> trivial matter of choosing what the image should look like = then =F0=9F=98=81) Whilst you=CA=BCre changing stuff, the text should not be "stop", it should be "suppress" or "ignore" or something. Robert --=20