From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61049: 29.0.60; xfaces.c:font_maybe_unset_attribute unused in nox build Date: Wed, 25 Jan 2023 01:15:06 +0000 Message-ID: <87a627za79.fsf@tcd.ie> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 61049@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 02:16:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKUOn-0007j8-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 02:16:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKUOU-00075k-Lr; Tue, 24 Jan 2023 20:16:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKUOR-00075S-3D for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 20:16:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKUOQ-0002fV-Qp for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 20:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKUOQ-0004u4-Er for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 20:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 01:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61049 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167460931918782 (code B ref -1); Wed, 25 Jan 2023 01:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jan 2023 01:15:19 +0000 Original-Received: from localhost ([127.0.0.1]:57875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKUNj-0004sr-0n for submit@debbugs.gnu.org; Tue, 24 Jan 2023 20:15:19 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKUNh-0004sj-3l for submit@debbugs.gnu.org; Tue, 24 Jan 2023 20:15:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKUNg-00072T-Rx for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 20:15:16 -0500 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKUNe-0002O9-JK for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 20:15:16 -0500 Original-Received: by mail-wr1-x42d.google.com with SMTP id h16so15550241wrz.12 for ; Tue, 24 Jan 2023 17:15:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=EgJ1je61HlW+07ii8c62FYXXGUrr/UaPTKIcfauIJfQ=; b=WMVHfKhtKAXnKl4bnCMguf8sIBY+MR0EjYLU7Hw9GbrIASeGQ2MyG6OQNzxlo2gs8K UilP6vcbkuYQgBj3iD6HhbhK7Ps58lrQnOt8osFJ6qUMjEHvTVD9uC5zVczLAc2R67SI RJIwXUvNoCplHbtlQ6NRYeTRJemF8V1/kz/RUPv8EOpH6EAlIpRkxxLSSugUhMiJjIRw xiAuI/amslDVWNxHEL15T1srdxko4Nrn0XsAZjaJqPKP+YUr+e3gxJMf5k6y9ojJV5XK f48FsE3g0BkrCIN4ESVupLcKLYZU/L6qspo1SVTubvMVhVjfpc156c5zLrRWC+7LD4cX Wc/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EgJ1je61HlW+07ii8c62FYXXGUrr/UaPTKIcfauIJfQ=; b=Nac1+XWNRyQJ5P1OFQ9cd4hnuvzDjxlqLeM8rL4lo87z4794ZQJ4Hni2Oi6rgQzzxq UmF577Kn9BG33BOomKqwZilT7nvqoaKsXVGfd/GeEnHY3Jc/L8dqspqLUHJWMW7SO8uN EhSKRUTqX4njn7pW1UrblL89jvoLF88yHOWAc12arRnlsCi4YwXm0SdzQEvtA9Ie4F0B 0Ef5SP5erLxHKmHY1rR5SMQI6/+HP1APC/3JJfh0wwJY2+D3fEzSRaBZw+S4k57EepWZ un7ziVppJyiDxapxNHCpXSXXuy/KWQTNnDhFBY01e9MAXvWfOVkhFa6uceoHH1XWUCnV 5Siw== X-Gm-Message-State: AO0yUKUwPliDOppIOVwmttKBVv8KHs9HxR6olFsP8RLv3eZd8CkzDODN eHfx1KR/bAiTRVWulCywd7OGWwMQkwaRk0u1 X-Google-Smtp-Source: AK7set8z2scfeBC/rL6+sCozt/mzc66l7EhLCZ/I2lDHrR+qyE97jOqyHAdEd4+GRznGypDoeE2HUQ== X-Received: by 2002:adf:a40b:0:b0:2bf:b4d1:af03 with SMTP id d11-20020adfa40b000000b002bfb4d1af03mr1834034wra.30.1674609309408; Tue, 24 Jan 2023 17:15:09 -0800 (PST) Original-Received: from localhost ([64.43.154.54]) by smtp.gmail.com with ESMTPSA id n17-20020a5d67d1000000b002425be3c9e2sm2974971wrw.60.2023.01.24.17.15.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 17:15:07 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254086 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severity: minor Tags: patch Building emacs-29 --without-x emits the following warning: xfaces.c:6021:1: warning: =E2=80=98font_maybe_unset_attribute=E2=80=99 defi= ned but not used [-Wunused-function] 6021 | font_maybe_unset_attribute (Lisp_Object font_object, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Okay to fix on emacs-29, or not important enough? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Pacify-without-x-unused-function-warning.patch >From befe5396b2b5aa7852ebb30988d1ed388c2d763a Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 25 Jan 2023 01:02:30 +0000 Subject: [PATCH] Pacify --without-x unused function warning * src/xfaces.c (font_maybe_unset_attribute): Move definition... [HAVE_WINDOW_SYSTEM] (font_maybe_unset_attribute): ...to here, since the function is used only when we HAVE_WINDOW_SYSTEM. --- src/xfaces.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xfaces.c b/src/xfaces.c index 68f7cc493cc..35b79154805 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -6012,7 +6012,6 @@ realize_non_ascii_face (struct frame *f, Lisp_Object font_object, return face; } -#endif /* HAVE_WINDOW_SYSTEM */ /* Remove the attribute at INDEX from the font object if SYMBOL appears in `font-fallback-ignored-attributes'. */ @@ -6031,6 +6030,7 @@ font_maybe_unset_attribute (Lisp_Object font_object, ASET (font_object, index, Qnil); } } +#endif /* HAVE_WINDOW_SYSTEM */ /* Realize the fully-specified face with attributes ATTRS in face cache CACHE for ASCII characters. Do it for GUI frame CACHE->f. -- 2.39.0 --=-=-= Content-Type: text/plain Thanks, -- Basil $ gcc --version gcc (Debian 12.2.0-14) 12.2.0 Copyright (C) 2022 Free Software Foundation, Inc. In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu) of 2023-01-25 built on tia Repository revision: ecf500b5e34f3767df6b41f110efcf307c74ebc9 Repository branch: wt/emacs-29-nox System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CFLAGS=-O2 -march=native' --prefix=/home/blc/.local --program-suffix=-29-nox --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND SQLITE3 THREADS TREE_SITTER XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow regexp-opt sort mail-extr emacsbug message mailcap yank-media puny dired dnd dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv bytecomp byte-compile rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 47477 6970) (symbols 48 5698 0) (strings 32 14970 1708) (string-bytes 1 435117) (vectors 16 8387) (vector-slots 8 104002 7945) (floats 8 24 40) (intervals 56 200 0) (buffers 984 10)) --=-=-=--