From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#61277: FR: ELPA security - Restrict package builds to signed git commits Date: Sun, 05 Feb 2023 11:19:59 +0000 Message-ID: <87a61se4v4.fsf@localhost> References: <87pmapqoo5.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37215"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61277@debbugs.gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 05 12:20:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOd4G-0009PK-Ap for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Feb 2023 12:20:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOd40-0004a5-Kh; Sun, 05 Feb 2023 06:20:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOd3y-0004Zu-HX for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 06:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOd3y-0000na-8p for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 06:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOd3x-0005fd-TQ for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 06:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61277 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca Original-Received: via spool by submit@debbugs.gnu.org id=B.167559597421758 (code B ref -1); Sun, 05 Feb 2023 11:20:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Feb 2023 11:19:34 +0000 Original-Received: from localhost ([127.0.0.1]:44165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOd3V-0005es-N7 for submit@debbugs.gnu.org; Sun, 05 Feb 2023 06:19:34 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:36694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOd3T-0005ej-3q for submit@debbugs.gnu.org; Sun, 05 Feb 2023 06:19:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOd3S-0004Wr-5p for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 06:19:30 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOd3P-0000hS-OQ for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 06:19:29 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8ADEE240127 for ; Sun, 5 Feb 2023 12:19:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1675595963; bh=pa20DwQYKne+GYC6G9+HoVdYRr/GmAdGwGEue3RDe8g=; h=From:To:Cc:Subject:Date:From; b=lYgi8ecWoZg3no+uHSY2QCi/FUDxvOe7u8F+7Eppl372SpBfAuR40Kd3/3TyisNPd /c/CVuJYVNbVgrWjy8jlFE1YBR5pwdFr8nDDlZrno5TMWnCa1JBS0tyxDMMK8G8sjD dCVQw3muZyjFJNVYy2umeFlFe/+JQXDMLCyZ3wJ8VxPYWNBOG6wdZ/0sT6XP9w5huK cFwUX4To9G6rWFRVZHDURcbVmVrWZCi3IkkOZw1uVF7zio3Yqs/Y8ty/chlhkx0iYu 4tKU8JAfPuyIm1DqwWIW5560cPY1QPkZtp0w1FuVeIFK5w7dlm0JFy/tVJ33oVj2Hd jdJ3v3s5ls2Fw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4P8n3D0RRJz6tmB; Sun, 5 Feb 2023 12:19:19 +0100 (CET) In-Reply-To: <87pmapqoo5.fsf@daniel-mendler.de> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254841 Archived-At: Daniel Mendler writes: > My git commits are usually signed, so one could check the signature of > each commit which leads to a package build. This feature could be opt-in > for now, enabled via an attribute :signature in the elpa-packages > configuration. Maybe elpa-packages could store the fingerprint(s) of the > expected GPG key(s)? I think that requiring every single commit to be signed is an overkill. Maybe just the release tags? I guess, :signature, if optional, may allow multiple levels of verification: 1. nil :: no verification 2. (tags key1 key2 ...) :: verify release tags to match any of the listed GPG keys 3. (commits key1 key2 ...) :: verify every commit I am not sure what would be the most reliable way to specify the keys. Also, people with write access to ELPA repo may be required to sign their commits -- in the case of security breach if the SSH key gets stolen, signing may be a barrier to protect altering the elpa-packages configuration from injecting malicious GPG keys. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at