From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fernando de Morais Newsgroups: gmane.emacs.bugs Subject: bug#61308: 28.2; icomplete --- Error in post-command-hook: wrong-type-argument Date: Wed, 08 Feb 2023 19:09:09 -0300 Message-ID: <87a61n6c8q.fsf@gmail.com> References: <87wn4vh6b9.fsf@gmail.com> <86cz6k1v3a.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32315"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 61308@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 08 23:10:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPsdl-0008B6-Jg for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Feb 2023 23:10:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPsdg-0005A5-20; Wed, 08 Feb 2023 17:10:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPsde-00059p-BQ for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 17:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPsde-0001fV-3O for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 17:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPsdd-0005li-Vr for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 17:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fernando de Morais Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2023 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61308 X-GNU-PR-Package: emacs Original-Received: via spool by 61308-submit@debbugs.gnu.org id=B61308.167589417622132 (code B ref 61308); Wed, 08 Feb 2023 22:10:01 +0000 Original-Received: (at 61308) by debbugs.gnu.org; 8 Feb 2023 22:09:36 +0000 Original-Received: from localhost ([127.0.0.1]:56832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPsdE-0005ku-H5 for submit@debbugs.gnu.org; Wed, 08 Feb 2023 17:09:36 -0500 Original-Received: from mail-oo1-f41.google.com ([209.85.161.41]:45689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPsdC-0005kg-GA for 61308@debbugs.gnu.org; Wed, 08 Feb 2023 17:09:35 -0500 Original-Received: by mail-oo1-f41.google.com with SMTP id c29-20020a4ad21d000000b00517a55a78d4so40210oos.12 for <61308@debbugs.gnu.org>; Wed, 08 Feb 2023 14:09:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=BRUFts8FD7cDE99qj0GsdVhONCJl+L/0qr+YzMoRNBk=; b=BzsxNeoW27h1c6DKNDn3dKWJ8peAc8oKduvOmhGS63UlDlTdWbpHJtnkm+flZpQ9xZ J80Ruthiomjy6IENcjrTglm6ejkhx/TBs6WCttaSxilwSwC4gDjnL76zJFPkik5NLnZv TvdNbBUiAHtXj+bi3UYL2gtim4az72YIuoXeuxim4SHHMHeOAW25AC8Jq8Gxm3b8M8ZI rfwOxJPS+3Yaq0gIOdVGqdZ2jcA8SW9dSCbDJwMe9pISEt7OmkyWNc+RFFK2n4faUafa HhWmR7Wmy8JAW8P6IMt9Z+I5spRL9pkIceMhoKOpcJhvRGvIqTPbHnKtDmHNF1kzQpDt RI5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BRUFts8FD7cDE99qj0GsdVhONCJl+L/0qr+YzMoRNBk=; b=YUwwGGSzFTTYvsLZRNMKT3qnnHaxKHhSzKa6md6ESKRCoVeJsAcTcl1h0Hm3xUG81A 3LeN6eWt3z8/khUUchdF24wUM3vg6rsq2nsCoaWBw5+5W5jU8B01br4lx7ueKgxYN2aO mO7geyx7OcaPomSWbsmFNGp/J9KxLm2nq/IH8IkuTZF60Y/nAe9bxG3MdWxel8XZP8jT 21dbBoCOYlNl6K5l+R36b9uWXr3l8TvoaGlAiD24TraO2Dk0NdzS+ffSrCBdRX9rgFls r5O6TE6vJDXc8edXglRuL2tP6n95PmI+Om8/1PUL0wpjX4oZl9Mhr0eOT7TeUywngFWp cWsw== X-Gm-Message-State: AO0yUKXAjqM4c+CmWxQYcmvzJUBWcbm/KT2WUG5p2UYzvm1+KOTA/s5X xTnsaTTpeAtuPwLK5+Exf5v42/vdiCU= X-Google-Smtp-Source: AK7set8KvTH8Rq3nrMN9eZTRffzOpei/K+6cJ86O5YjbX4/xwdopgGncE5LgM1qHFAiZKVZ3V1gM/g== X-Received: by 2002:a4a:cb8e:0:b0:4fb:cef6:5c9d with SMTP id y14-20020a4acb8e000000b004fbcef65c9dmr4063909ooq.9.1675894168599; Wed, 08 Feb 2023 14:09:28 -0800 (PST) Original-Received: from sekai ([2804:14c:da80:82e2::4cf]) by smtp.gmail.com with ESMTPSA id h13-20020a4aa28d000000b004fd878ef510sm7999882ool.21.2023.02.08.14.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 14:09:28 -0800 (PST) In-Reply-To: <86cz6k1v3a.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 08 Feb 2023 09:20:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255166 Archived-At: Hello Juri, Juri Linkov writes: > Interesting bug report. I guess we need to double-check > if we are still in the right buffer after help-window-select > selects another window and thus confuses icomplete-mode: > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > index 014f38b2024..97457832e2c 100644 > --- a/lisp/icomplete.el > +++ b/lisp/icomplete.el > @@ -686,6 +686,8 @@ icomplete-exhibit > Should be run via minibuffer `post-command-hook'. > See `icomplete-mode' and `minibuffer-setup-hook'." > (when (and icomplete-mode > + ;; Check if still in the right buffer (bug#61308) > + (or (window-minibuffer-p) completion-in-region--data) > (icomplete-simple-completing-p)) ;Shouldn't be necessary. > (let ((saved-point (point))) > (save-excursion This solved the problem, thank you! =F0=9F=A4=9D I hope this path gets merged upstream. --=20 Regards, Fernando de Morais.