From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61624: 30.0.50; [PATCH] More doc on image-dired-dired-* Date: Sun, 19 Feb 2023 14:16:34 +0100 Message-ID: <87a619sslp.fsf@ledu-giraud.fr> References: <87edqlsx6y.fsf@ledu-giraud.fr> <83y1otx3m4.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36581"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61624@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 14:17:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTjZG-0009Lj-Te for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 14:17:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTjYx-0008Br-Kx; Sun, 19 Feb 2023 08:17:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTjYs-0008BR-OB for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 08:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTjYs-0005BP-F3 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 08:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTjYs-0006JI-5O for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 08:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61624-submit@debbugs.gnu.org id=B61624.167681260124223 (code B ref 61624); Sun, 19 Feb 2023 13:17:02 +0000 Original-Received: (at 61624) by debbugs.gnu.org; 19 Feb 2023 13:16:41 +0000 Original-Received: from localhost ([127.0.0.1]:45945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTjYW-0006Ic-Mu for submit@debbugs.gnu.org; Sun, 19 Feb 2023 08:16:41 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:34811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTjYT-0006IS-LS for 61624@debbugs.gnu.org; Sun, 19 Feb 2023 08:16:38 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=tbFHII8u mpQeA/1U4GUJl5QZCuCw3Ddvnk3sO5z6Vno=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=0WG3+ySninL1gE7sqCQTbmaENXDY0l xuFzttoHyQMR8UVTUOGlAH+ALfvomcNUya5uul12/Pl1cYtHYkmb0MAQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=tbFHII8umpQeA/1U 4GUJl5QZCuCw3Ddvnk3sO5z6Vno=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=aeTpR/VJ3IcunAj+9+w9zlvzfVJoj/suBmzznf nL3YjHMRYSyaQdIJKfpWOCgDO2MuHFLCXt3kOCQLeIJ3bayBAOGg72a2S9dvwAQm7SvEq+ XcDU90wu2v6D/g3m6K+HcU/LtqPfLIG5i1XzMptPELP4VNWZgcXWwnSkjevqQhL7ml/vtw wVkamzggzPvPrLjl8UmU2oOJaD4zew8SmodyUNn7uQTlyYc/f+NXnodipbb/U/DE6tnYEn ADm2t3G2ihuyStgkzIzwImNR4M8fcrRHc/m/vFUv9KAzE+rUnETcboLJbEqujRa27Te5xe FlxQODWttjD/owlamTcpnjuA== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 21bbf8a4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 19 Feb 2023 14:16:36 +0100 (CET) In-Reply-To: <83y1otx3m4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Feb 2023 14:05:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256065 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Thanks. I have a few comments: Hi Eli, Here is a new version that adresses most of your comments. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-More-doc-on-image-dired-dired-bug-61624.patch >From ecfd819be00aaeb04171df0858752ae55ac1333b Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sun, 19 Feb 2023 12:19:02 +0100 Subject: [PATCH] More doc on image-dired-dired-* (bug#61624) * doc/emacs/dired.texi (Image-Dired): Some fixes and more documentation about image-dired-dired-* commands. --- doc/emacs/dired.texi | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/doc/emacs/dired.texi b/doc/emacs/dired.texi index cae8207990e..d78443271b6 100644 --- a/doc/emacs/dired.texi +++ b/doc/emacs/dired.texi @@ -1655,11 +1655,11 @@ Image-Dired @findex image-dired-display-previous With point in the thumbnail buffer, you can type @key{RET} (@code{image-dired-display-this}) to display the image in another -window. Use the arrow keys to move around in the thumbnail buffer. -For easy browsing, use @key{SPC} (@code{image-dired-display-next}) to -advance and display the next image. Typing @key{DEL} -(@code{image-dired-display-previous}) backs up to the previous -thumbnail and displays that instead. +window. Use the standard Emacs movement key bindings or the arrow +keys to move around in the thumbnail buffer. For easy browsing, use +@key{SPC} (@code{image-dired-display-next}) to advance and display the +next image. Typing @key{DEL} (@code{image-dired-display-previous}) +backs up to the previous thumbnail and displays that instead. @vindex image-dired-external-viewer Type @kbd{C-@key{RET}} @@ -1669,10 +1669,20 @@ Image-Dired You can delete images through Image-Dired also. Type @kbd{d} (@code{image-dired-flag-thumb-original-file}) to flag the image file -for deletion in the Dired buffer. You can also delete the thumbnail +for deletion in the Dired buffer. You can also remove the thumbnail image from the thumbnail buffer with @kbd{C-d} (@code{image-dired-delete-char}). +@findex image-dired-dired-toggle-marked-thumbs +@findex image-dired-dired-display-external +@findex image-dired-dired-display-image + You could also use Image-Dired for ``inline'' operations (i.e., +right into the Dired buffer). Type @kbd{C-t C-t}, and the thumbnails +of the selected images in Dired will appear in front of their names +(@code{image-dired-dired-toggle-marked-thumbs}). @kbd{C-t i} and +@kbd{C-t x} will display the image under the point in Emacs or with +the external viewer, respectively. + More advanced features include @dfn{image tags}, which are metadata used to categorize image files. The tags are stored in a plain text file configured by @code{image-dired-tags-db-file}. @@ -1684,14 +1694,18 @@ Image-Dired (@code{image-dired-mark-tagged-files}). After marking image files with a certain tag, you can use @kbd{C-t d} to view them. +@findex image-dired-dired-comment-files +@findex image-dired-dired-edit-comment-and-tags You can also tag a file directly from the thumbnail buffer by typing -@kbd{t t} and you can remove a tag by typing @kbd{t r}. There is also -a special tag called ``comment'' for each file (it is not a tag in -the exact same sense as the other tags, it is handled slightly -differently). That is used to enter a comment or description about the -image. You comment a file from the thumbnail buffer by typing +@kbd{t t}, and you can remove a tag by typing @kbd{t r}. There is +also a special tag called ``comment'' for each file (it is not a tag +in the exact same sense as the other tags, it is handled slightly +differently). That is used to enter a comment or description about +the image. You comment a file from the thumbnail buffer by typing @kbd{c}. You will be prompted for a comment. Type @kbd{C-t c} to add a comment from Dired (@code{image-dired-dired-comment-files}). +@kbd{C-t e} will bring a buffer to edit comment and tags +(@code{image-dired-dired-edit-comment-and-tags}). @vindex image-dired-thumb-visible-marks Files that are marked in Dired will also be marked in Image-Dired if -- 2.39.1 --=-=-= Content-Type: text/plain [...] >> You can delete images through Image-Dired also. Type @kbd{d} >> (@code{image-dired-flag-thumb-original-file}) to flag the image file >> -for deletion in the Dired buffer. You can also delete the thumbnail >> +for deletion in the Dired buffer. You can also remove the thumbnail >> image from the thumbnail buffer with @kbd{C-d} >> (@code{image-dired-delete-char}). > > Not sure I understand the reason for this. "Deletion" goes together > with "delete", so why use "remove" instead? You're right that it goes with "delete" from the command name but I thought that "remove" is better because no file is deleted from this operation. Only the thumbnail is removed from the thumbnails buffer. Maybe my english is a bit off here. -- Manuel Giraud --=-=-=--