From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Sat, 25 Feb 2023 15:14:06 +0100 Message-ID: <87a61125ox.fsf@gmail.com> References: <87a614g628.fsf@gmail.com> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <87lekn9ss3.fsf@gmail.com> <83h6vbntqd.fsf@gnu.org> <878rgn9r6u.fsf@gmail.com> <83edqfnq5u.fsf@gnu.org> <83bkljnpck.fsf@gnu.org> <874jrb9l6d.fsf@gmail.com> <834jrbnlaf.fsf@gnu.org> <87v8jr83ic.fsf@gmail.com> <83v8jrm4r0.fsf@gnu.org> <87fsav7x81.fsf@gmail.com> <83a612ko73.fsf@gnu.org> <87ttza3rwh.fsf@gmail.com> <83356tluvq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61726@debbugs.gnu.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 25 15:15:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVvKd-0007LM-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Feb 2023 15:15:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVvKL-00038p-Lm; Sat, 25 Feb 2023 09:15:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVvKJ-00038d-Iq for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 09:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVvKI-00041D-Px for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 09:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVvKI-0008Tr-GH for bug-gnu-emacs@gnu.org; Sat, 25 Feb 2023 09:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Feb 2023 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.167733445732522 (code B ref 61726); Sat, 25 Feb 2023 14:15:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 25 Feb 2023 14:14:17 +0000 Original-Received: from localhost ([127.0.0.1]:39385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVvJY-0008SU-N2 for submit@debbugs.gnu.org; Sat, 25 Feb 2023 09:14:16 -0500 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:39468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVvJX-0008SF-9V for 61726@debbugs.gnu.org; Sat, 25 Feb 2023 09:14:15 -0500 Original-Received: by mail-ed1-f50.google.com with SMTP id f13so8315963edz.6 for <61726@debbugs.gnu.org>; Sat, 25 Feb 2023 06:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hlrTxRUk9yp1gMw7YVu+yKifDKjMbUAtTk1F08fLu5I=; b=Dk394zew6MaeZpmweFLTfcdqI8vvNn/8sGuByJfUzf9CPZddz6jHeE+DQ/LVYyPeqx xqfMIUqD2/CJujUfbwP6NYz8jyU+tSJjszS3EfA9zQr5iI1qwk3/u9ghq9ciJv37u4jv 70lsM9NUOErNz8tRacBKh5M7pe1jvyPcGtr+Jxj6FYwYT3aGmdcGpDxfqlCgRSK3NUXc BHjc8AlIdaP323DIAP93jFGanzbuwAwqADRaRbTj0RuHvcCZM7/tf/EYd9KlfhKaLwQG EEKFG5q0R7Jr9hT5Tgraz1z3FJ3GRpoqcq2zqMotzPrgeYowzHvOitDT4qlhvuauWS6l U1JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hlrTxRUk9yp1gMw7YVu+yKifDKjMbUAtTk1F08fLu5I=; b=6jJfKcjst/CHelYLKIT4d79Rs2GPQzCKX5u33bnwfgkmqZ0h0M4BN6GgX3d9wnJgob VLGO0TDYjwkiXwzHh8Yf5dokDJ6vvgzlSdyw7j6zW1UtKIRg/Abl5M0Pjh+i+xNQleho JVyEBVY8bZBeaTv+H8RWp70DvJl1/yko1TWuyZ8Vjae0b1mUsa4PvKEoFystPwzGq874 Z8C/pf2RXnSQw28pHb0x/r8/Pis8Il/ZMtiqRX/hjC4a6OGZpUzVIATxeOJ0I/fkH3pe uUJbMV7caGu7ISh7plLN1s8/HInlusZfXAqkNW3wkhCnoHprj1iR2Wpx9StEuuBTdF2Q 2z5w== X-Gm-Message-State: AO0yUKUuesOnDnUJ0vlrhBQWaMGop/berVF0vDZygIiZNzYA/bkFGxyJ tMzyQvM8jsU4bOFPg1gvrDMRc03JIb9DEw== X-Google-Smtp-Source: AK7set9uO/2TLDdLLymhIvpP5qM0WE8rGL4jtu+EfkoYS8ER7XWZ7ApRzMUOw5caurNh/3K0Og8F3w== X-Received: by 2002:a17:907:7851:b0:8b2:3eb6:8658 with SMTP id lb17-20020a170907785100b008b23eb68658mr30471404ejc.0.1677334448989; Sat, 25 Feb 2023 06:14:08 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id 13-20020a508e0d000000b004af6e957b22sm908129edw.6.2023.02.25.06.14.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 06:14:08 -0800 (PST) In-Reply-To: <83356tluvq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Feb 2023 15:47:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256724 Archived-At: On Sat, 25 Feb 2023 at 15:47, Eli Zaretskii wrote: >> > Can you please humor me and implement eglot-bytewise-column like that? >> >> I would be glad to do that, but unfortunately I'd have to ask your >> advice as to how to make the corresponding adaptation of >> eglot-move-to-bytewise-column. ^^^^^^^ > Instead of this: > > (defun eglot-bytewise-column () > "Calculate current column using the LSP `utf-8' criterion." > (- (position-bytes (point)) (position-bytes (line-beginning-position)))) > > use this: > > (defun eglot-bytewise-column () > "Calculate current column using the LSP `utf-8' criterion." > (length (encode-coding-region (line-beginning-position) (point) > 'utf-8-unix t)))