From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#62207: 29.0.60; Trying to remove non-existent key binding instead adds a binding Date: Sat, 18 Mar 2023 10:43:26 +0100 Message-ID: <87a60as8ch.fsf@gmail.com> References: <875yb2gfqp.fsf@bernoul.li> <83pm9aq6of.fsf@gnu.org> <83ttyjeqgm.fsf@gnu.org> <87ilezu5aq.fsf@gmail.com> <83pm97ehpb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, Eli Zaretskii , jonas@bernoul.li, 62207@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 10:44:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdT6r-00035a-8D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 10:44:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdT6d-0003qz-I1; Sat, 18 Mar 2023 05:44:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdT6Y-0003q2-BI for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 05:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdT6Y-0002Dq-3B for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 05:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdT6X-0006oU-VA for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 05:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 09:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 62207-submit@debbugs.gnu.org id=B62207.167913261626145 (code B ref 62207); Sat, 18 Mar 2023 09:44:01 +0000 Original-Received: (at 62207) by debbugs.gnu.org; 18 Mar 2023 09:43:36 +0000 Original-Received: from localhost ([127.0.0.1]:46224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdT67-0006nc-QO for submit@debbugs.gnu.org; Sat, 18 Mar 2023 05:43:36 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:46732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdT65-0006nN-BJ for 62207@debbugs.gnu.org; Sat, 18 Mar 2023 05:43:34 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id r29so6318364wra.13 for <62207@debbugs.gnu.org>; Sat, 18 Mar 2023 02:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679132607; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=O5rMkeaV5DICjvITKUDymWa/XfzL1TLvu2ZSEf2LH68=; b=PDij7yUQJd39UP63BY1H3C1muQ6bmAL3LpegZPt5JtFXl0Zh1t2K9aPrWHztro4C0Q N7OhzBx12mY+b74YE4Mc2JVKJO5h/EXLwAa8hJWZXPMm55tDvhYYgIKVx3BxcOLGvOOl 4zjcnqAGnxONkee/OtR4d1q0ObQJyAGZFWri35SnYYF6YHm6B9Yup0AJodENZmqmxjjM G6uzmaNuMnXx7RVAC1bdzDlLnFdTHYe1Sz3xZhnnZOjAmnhPIct0dlyOo8X1Vwbkf3pT t7y/Pf0EPJglHUhO1aqlWwj2Sgrq4DmksAnaGZ3bqPcLgm7TB4VrsyWgMwSnNOwrTgeJ FjmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679132607; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O5rMkeaV5DICjvITKUDymWa/XfzL1TLvu2ZSEf2LH68=; b=tPlG+ogfTY0xDvVd4OXSkwMWerjABfR/tXI6nxJUf9AkBR3VNL9o5BB2mTgjs/diRh 3TpiN8TXD8tRpQx8WyONCRumXmXaeAQKq3V+ONbab/bOo2/9nsDrkEcZNnzYwGVcXbsB FS04ipA8uMtSqzLz/RZcmIxHa7eEkLcFwCBAQ6iaKO/7m9Uz/9qsm9pi7iH+ZiwWWHMS xgRUtGpt3NT5WuCGOEqyVdfCEuYt8CBxX1GNVQ8b2WNxZy5cagBQ5uCT5vi1ycQXy74j 57ZvJHd+N0Iio9/J41nfU5o1oWSsdf/ZJcmwr9PKKShk9Mib77o6nCPVDl+a/XJXxTsH DM7w== X-Gm-Message-State: AO0yUKUWAHeTZ+zV9YERRJMj+uUjUW+m0xSOdSNPTERRS8BrGqPHCPpr rf18J0D4Xv/LldCvkm4nNt4= X-Google-Smtp-Source: AK7set+MCvZr8AFwVr4rurhtBk+q+7Y80a3fp1k3UT7qAnpNwMljqP6xeWwjCsfOLiDtM2vDn8a4Gg== X-Received: by 2002:a5d:5508:0:b0:2cf:ef5b:49d4 with SMTP id b8-20020a5d5508000000b002cfef5b49d4mr8999235wrv.48.1679132607235; Sat, 18 Mar 2023 02:43:27 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v15-20020a5d590f000000b002cfec8b7f89sm3944798wrd.77.2023.03.18.02.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 02:43:26 -0700 (PDT) In-Reply-To: (Stefan Monnier via's message of "Fri, 17 Mar 2023 16:51:56 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258150 Archived-At: >>>>> On Fri, 17 Mar 2023 16:51:56 -0400, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: >> If this part is still controversial, I'm okay with only fixing the bug >> itself. As for REMOVE, let's see what Stefan has to say in defense of >> his request, and take it from there. Stefan> I can't remember off-hand all the subtleties that can show up in corner Stefan> cases, but I'll simply note that the current removal code is already the Stefan> result of my pointing out several not-so-corner cases that the original Stefan> coder missed (even though he was not a beginner at the keymap game), and Stefan> this very bug report illustrates that the code is still buggy. Stefan> [ Which reminds me that we need a regression test for this. ] Done. Let me know if there are corner cases I missed. Stefan> I think the removal code is "good enough" for uses in a user's init Stefan> code, but I'd rather add some recommendation to avoid on it in Stefan> ELisp packages. We can put that in the elisp manual, no? Robert --