From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#62952: 28.2.50; secrets.el unlocking items Date: Mon, 08 May 2023 13:42:44 +0200 Message-ID: <87a5yfaw23.fsf@gmx.de> References: <87fs8u6bm1.fsf@gmx.de> <0a74e18e-d972-43b6-b661-cee36b08ddb4@app.fastmail.com> <871qjzgdow.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62952-done@debbugs.gnu.org To: "Philipp Uhl" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 08 13:43:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvzH1-00073s-Km for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 May 2023 13:43:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvzGk-0008Fw-Jm; Mon, 08 May 2023 07:43:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvzGg-0008FW-Gw for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 07:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvzGg-0008GT-6t for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 07:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvzGg-0001lA-2a for bug-gnu-emacs@gnu.org; Mon, 08 May 2023 07:43:02 -0400 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 May 2023 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62952 X-GNU-PR-Package: emacs Mail-Followup-To: 62952@debbugs.gnu.org, michael.albinus@gmx.de, git@ph-uhl.com Original-Received: via spool by 62952-done@debbugs.gnu.org id=D62952.16835461776748 (code D ref 62952); Mon, 08 May 2023 11:43:01 +0000 Original-Received: (at 62952-done) by debbugs.gnu.org; 8 May 2023 11:42:57 +0000 Original-Received: from localhost ([127.0.0.1]:39469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvzGb-0001km-A4 for submit@debbugs.gnu.org; Mon, 08 May 2023 07:42:57 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:44513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvzGY-0001kT-7H for 62952-done@debbugs.gnu.org; Mon, 08 May 2023 07:42:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1683546164; i=michael.albinus@gmx.de; bh=oMpKf8JuyazveMetKqCV3JS7rREJpStbWMaUmrNKNSo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=RknNs+sdDukH1Mq9lhNBp8UQIN+nGfP6F7x5dEH1x1EbKTKeOU2WDxB0oY5Ztzl9J nW65F8EuOHSuioDvhU8/fEXRA6Ig+62xQGJd6r5AsCZ14EWHIJLQ3+CD7D/9t0Wr4Y 8w267BLs/p12mbA5BpfUYEQ6rpzoe1Kloy18/IzkMsWtNiXx6sqtyr7QCM1vQr/tv6 NmpyABYwOJ8oF6y35SIxjsxheXtSyoZB9i8GJB1v3PLtwMQe3vAeg/x06c8+2rPIQ0 N0Eplfq7PTpNtLoMgcFs4ZNQi5zlneOQ+4H0owUj8gr+IOCIZSgDPuCQ+f0YQQheUT CO2ok7yS3myFw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MeU0q-1qW9Ue3OoW-00aRtY; Mon, 08 May 2023 13:42:44 +0200 In-Reply-To: <871qjzgdow.fsf@gmx.de> (Michael Albinus's message of "Tue, 02 May 2023 13:44:47 +0200") X-Provags-ID: V03:K1:V0pZH3a2wW6LV4tJbuvYdnzkE1lSKRpWypcb9AUYyaFzasUHSC/ NSpTKaYRxNtNiaVEbT9fArzhpcYiBeHZ/gV72/BMcAzG7QYJMphVDACoinLV6FQIzYHIGTg CNGNA4eFC+dg26dhpzr1GqYWbL1irMBDbzstV8Mm+oR9FfBa3y657FzxLJIuqoGEOiVrLzZ 8/2PPK2dCtw7BPhiP8+UQ== UI-OutboundReport: notjunk:1;M01:P0:N3Fdmc/w9XU=;1xHXTWWY6z6WEzdJcDNhKz/4Dxq YhernIByVuvZ7j0Yd71F5SZekaScNOzMZZagIBiDaF6c1qfuQ74HOCsMBWIWG5xVniClfKxWj aJT432oZKZznjWgg4tdlJB8JvGSP3ss68t93qyEzWNCoNVoEsR1bzYN/RlaU9pMRcGHA1zdk7 dMbSPl2JmCimVKP98EyhKCM/CFmJ97poBQAh6/k7K4FI+D4wsA09rsaudenVa1LZG+oOmvwZj wjPQ0OeMz3kD6qSLfuOKXF7jANd28RycGpW83yQBRefbS3iyC3psptdIqbvUg5BKufYNB3QTN 28cZBwQB2BfhqrSRT/oQjjFrBQ+EsjOhA/GyMpRge3Qrz/nOYBkk82chvoQhvDDvTVQ35h9XX tdsEuK3MmhTZNdDiaPeGcZp9fvuiPsv6DOxB23I+dbtyqVsZOaA2yAF8qWlD8H9eFrVhCdOgf 9AM4OsSn+Kw52XtamEtzWMJle3q+rwB1qw41xbWT8EQYYxIv79NS4DbcasrUYUiVtdtevKg8Q bXzoIlDw35Xo0ZSPWv2D7R6mkxIIeqfoVmN5zmQVR6pgfOsZDM9Toph8xsMSiFAf7ke73hgMY xE5L+JtsjU6iI21uFDLpJkZ71f5ICBpZ5IIx9oKgsHh+ukav+mGPdkujBTPEN4Ezvht6zsIPS SgbEZOKZY+kr1i8aIAWOizVhqd/2TR8k+lQxPcAqB77WgRshwx5F+NSbFrqcQ6JMKeQxaulS0 P/H+GirKM5QnJbvze+R/TDal4QoMhAwoPHq156B1fSFMex5rLG424yyfdgz5N5eS3aBU/b7c X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261310 Archived-At: Version: 30.1 Michael Albinus writes: Hi Philipp, >> thanks for your response. Here is the secrets-lock-item function: > > Thanks. I'll check it next days. I've played this morning with your changes. Everything looks fine (in my environment), so I have pushed them to the Emacs master branch. >>> Bonus points for respective tests in secrets-tests.el. >> >> I didn't find any secrets-tests.el in the Emacs repository. Also I am >> not really familiar with writing test code in Elisp. But I did >> manually test the code and it works. > > See test/lisp/net/secrets-tests.el in the git repository. Tests are > performed using ERT, see (info "(ert) Top") for the manual. I've tried to see how it works with this, but it looks like the temporary "session" session of Gnome keyring, which I use, doesn't care about locking/unlocking of single items. So likely it isn't worth to extend secrets-tests.el. I'm closing the bug. >> Cheers, Philipp Best regards, Michael.