From: Philip Kaludercic <philipk@posteo.net>
To: Tony Zorman <soliditsallgood@mailbox.org>
Cc: 63541@debbugs.gnu.org, Steven Allen <steven@stebalien.com>
Subject: bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled
Date: Thu, 18 May 2023 19:54:50 +0000 [thread overview]
Message-ID: <87a5y1za7p.fsf@posteo.net> (raw)
In-Reply-To: <20230516231204.40043-1-steven@stebalien.com> (Steven Allen's message of "Tue, 16 May 2023 16:12:04 -0700")
Steven Allen <steven@stebalien.com> writes:
> * lisp/use-package/use-package-core.el (use-package-handler/:vc):
> Return the new 'body'. Otherwise, the entire package declaration gets
> dropped when byte-compiling.
> ---
> lisp/use-package/use-package-core.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el
> index 0d99e270a3f..e0e16134ed3 100644
> --- a/lisp/use-package/use-package-core.el
> +++ b/lisp/use-package/use-package-core.el
> @@ -1619,7 +1619,8 @@ defvar use-package--form)
> ;; See `use-package-handler/:ensure' for an explanation.
> (if (bound-and-true-p byte-compile-current-file)
> (funcall #'use-package-vc-install arg local-path) ; compile time
> - (push `(use-package-vc-install ',arg ,local-path) body)))) ; runtime
> + (push `(use-package-vc-install ',arg ,local-path) body)) ; runtime
> + body))
>
> (defun use-package-normalize--vc-arg (arg)
> "Normalize possible arguments to the `:vc' keyword.
CC'ing Tony, since he did most of the work here. Do you have any
comments on this change?
next prev parent reply other threads:[~2023-05-18 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 23:12 bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled Steven Allen
2023-05-18 19:54 ` Philip Kaludercic [this message]
2023-05-19 15:16 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-20 16:50 ` Philip Kaludercic
2023-05-21 9:32 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-26 4:54 ` Steven Allen
2023-05-31 13:23 ` Eli Zaretskii
2023-05-31 21:53 ` Philip Kaludercic
2023-06-03 7:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5y1za7p.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=63541@debbugs.gnu.org \
--cc=soliditsallgood@mailbox.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).