From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64595: 30.0.50; 13-years old commented code in src/data.c:1608 (set_internal) Date: Thu, 13 Jul 2023 12:31:03 +0000 Message-ID: <87a5w0ngc8.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31337"; mail-complaints-to="usenet@ciao.gmane.io" To: 64595@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 14:32:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJvUj-0007sx-Pj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 14:32:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJvUP-0008Ld-Ig; Thu, 13 Jul 2023 08:32:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvUM-0008L8-27 for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 08:32:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJvUJ-0004Mu-3b for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 08:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJvUI-0007KG-Co for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64595 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168925146728098 (code B ref -1); Thu, 13 Jul 2023 12:32:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jul 2023 12:31:07 +0000 Original-Received: from localhost ([127.0.0.1]:53560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJvTO-0007J8-GV for submit@debbugs.gnu.org; Thu, 13 Jul 2023 08:31:06 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJvTK-0007Im-3B for submit@debbugs.gnu.org; Thu, 13 Jul 2023 08:31:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvTJ-00088r-Rs for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 08:31:01 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvTG-00031E-Mf for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 08:31:01 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id ABFF0240101 for ; Thu, 13 Jul 2023 14:30:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689251455; bh=++mbBonTbgyYyVYzq2FHI7+lCL/kxOD9XVpEF5Pwhn0=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=n/sWQtbZKGdkR5IAquraf0KafJ4HCb+jm7eBe4UDw1gI+x0JB3CSdMBvho32LDcJS eHHdcBTC2c9Z1kCYsg3TlsKXmSi3zxnnXeD1ZAWLqiWk+JFuttIYUz2l0f0VxQCAVZ jDdX5vkYB82pmAguufYY/9WdevP7oI3xM88fDep8LE5YZMAli+CHdD9fZtQ1uXSHGU Unl06YRVfpz4NpkDtVdEZok4AaIYmp5TkFP/5e23ur3Slf7uGDQSeqZ0v0iOjDrViP Zf4h6P6QGw40J5u7nBkyzwvAE8Tm2r34IuDVHw1I0RQIZwkt+1Uss9oXQrJgXf+ram RxZBpm37xUw/Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R1v8t3SjLz9rxG for ; Thu, 13 Jul 2023 14:30:54 +0200 (CEST) Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265016 Archived-At: Hello, While reading the sources, I found the following commented piece of code in set_internal: /* If restoring in a dead buffer, do nothing. */ /* if (BUFFERP (where) && NILP (XBUFFER (where)->name)) return; */ This code has been changed 13 years ago and also commented immediately (in the same commit): 94b612ad880e0d6eab6659347cb66e3a5310f8be Author: Stefan Monnier AuthorDate: Fri May 7 16:33:00 2010 -0400 Try and fix unbind_to when localness of binding has changed * eval.c (unbind_to): Don't unbind a local binding into the global binding when the local binding disappeared. Inversely, don't unbind a global binding into a newly created local binding. * data.c (set_internal): Make its `buf' arg into a `where' arg so we can specify the frame to use, when applicable. Adjust callers. - if (buf == 0) - buf = current_buffer; - /* If restoring in a dead buffer, do nothing. */ - if (NILP (buf->name)) - return; + /* if (BUFFERP (where) && NILP (XBUFFER (where)->name)) + return; */ I assume that after 13 years, it is safe to remove it. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-06 built on localhost Repository revision: d97b77e6c66db46b198c696f83458aa141794727 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Gentoo Linux -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at