From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Thu, 27 Jul 2023 09:28:11 +0000 Message-ID: <87a5vh7lg4.fsf@localhost> References: <87r0p030w0.fsf@yahoo.com> <83sf9f6wm0.fsf@gnu.org> <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> <83bkg2tsu6.fsf@gnu.org> <83bd4246-ac41-90ec-1df3-02d0bd59ca44@gutov.dev> <834jlttv1p.fsf@gnu.org> <937c3b8e-7742-91b7-c2cf-4cadd0782f0c@gutov.dev> <83a5vlsanw.fsf@gnu.org> <69a98e2a-5816-d36b-9d04-8609291333cd@gutov.dev> <87351cs8no.fsf@localhost> <35163e56-607d-9c5b-e3e8-5d5b548b3cb7@gutov.dev> <878rb3m43b.fsf@localhost> <83v8e6lyi4.fsf@gnu.org> <87lef17ok8.fsf@localhost> <83edktn3k4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15614"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, dmitry@gutov.dev, 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 27 11:34:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOxOW-0003md-8y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jul 2023 11:34:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOxIu-0003ZS-0L; Thu, 27 Jul 2023 05:29:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOxIs-0003YP-Ri for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 05:29:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOxIs-0002A1-Hx for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 05:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOxIs-0003CE-CI for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 05:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jul 2023 09:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.169045008912216 (code B ref 64735); Thu, 27 Jul 2023 09:29:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 27 Jul 2023 09:28:09 +0000 Original-Received: from localhost ([127.0.0.1]:40761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOxI0-0003Ay-MX for submit@debbugs.gnu.org; Thu, 27 Jul 2023 05:28:09 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:34351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOxHy-0003AT-ED for 64735@debbugs.gnu.org; Thu, 27 Jul 2023 05:28:07 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5357B240028 for <64735@debbugs.gnu.org>; Thu, 27 Jul 2023 11:27:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690450080; bh=Ytd8VeSAvDPI0pZncAHkopW37IDlkzXaSTuFZBDLBSA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=UZIc4HoR+pQI+aMOoSRzZ9ejnXSvibXMSBwegGokQiXpH6jx0/ghEu73ZGnnainhK sSR7XSArREeddIioxcbp1X2l0YuMbzeylTan32ZivAJIVG9n5PFdPZdf08JHmPyXaN u7naM8/PGZPU2xstIauSJMOycl7lXVKI0QSBYZYdPApDsFTY5pEJ41HbuSNDidLTiZ ctTz3jVMoLxN7Pr8Je5iQxP/ExDDEi8EnzSs4GlSimRGFvuiZYZta/6yoSwH6z8HWc F9bpnJRn3qc75IfXMEGj9RFD+8J5LqhITfwOTbGHiyLx/qJRPbJAEb8+ZARKHG08hV QSPV1h9T43iSQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RBQRL3pxJz9rxQ; Thu, 27 Jul 2023 11:27:58 +0200 (CEST) In-Reply-To: <83edktn3k4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266180 Archived-At: Eli Zaretskii writes: > And if this is about testing REGEXP for being a trivial one, adding > such a test to the existing code is trivial, and hardly justifies an > objection to what I wrote. I was replying to your interpretations on why I included "no-regexp" test. I agree that we should not use this test as comparison with GNU find. But I also wanted to say that adding the trivial REGEXP test will be useful. Especially because it is easy. Should I prepare a patch? >> Isn't `file-name-all-completions' more limited and cannot accept >> arbitrary regexp? > > No, see completion-regexp-list. That would be equivalent to forcing `include-directories' being t. In any case, even if we ignore INCLUDE-DIRECTORIES, there is no gain: (my-bench 10 "/usr/src/linux/" "") (("built-in non-recursive no filename handler alist" . "Elapsed time: 5.780714s (4.352086s in 6 GCs)") ("built-in non-recursive no filename handler alist + completion-regexp-list" . "Elapsed time: 5.739315s (4.359772s in 6 GCs)")) (let ((gc-cons-threshold most-positive-fixnum)) (my-bench 10 "/usr/src/linux/" "")) (("built-in non-recursive no filename handler alist" . "Elapsed time: 1.267828s") ("built-in non-recursive no filename handler alist + completion-regexp-list" . "Elapsed time: 1.275656s")) In the test, I removed all the `string-match' calls and instead let-bound (completion-regexp-list (list regexp)) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at