From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Date: Tue, 01 Aug 2023 18:32:08 +0000 Message-ID: <87a5vak40n.fsf@posteo.net> References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38325"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64985@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 01 20:33:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQuBS-0009pH-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Aug 2023 20:33:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQuBE-0001kR-1H; Tue, 01 Aug 2023 14:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQuB5-0001jz-GX for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 14:33:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQuB5-0003oq-6f for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 14:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQuB4-0006hB-8B for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 14:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091473925685 (code B ref 64985); Tue, 01 Aug 2023 18:33:02 +0000 Original-Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 18:32:19 +0000 Original-Received: from localhost ([127.0.0.1]:48322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuAM-0006gC-UE for submit@debbugs.gnu.org; Tue, 01 Aug 2023 14:32:19 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuAK-0006fw-Bl for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 14:32:17 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 33944240027 for <64985@debbugs.gnu.org>; Tue, 1 Aug 2023 20:32:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690914730; bh=cvB0qrOlFPuFh2LV3B7FwWHmGIyQTNIjdOqvEle29Y0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=QzFuLXx+RvhMpGDhc9C/VhCGkB/IShG1WthBWKQ9xEo2NqwFAlFeIPgjpkYJUlY1J mY5VFH3tl1Iw0wdLDUkARVnBsIQKsPS2bAuKYZJ7A4P76g83CC44aInsXGtF/yjOl3 XNG0peX0emZXYNBMch7WTZldIg03c9MsUejlZuANC3DbptOyaJFVm69zcjFIWJCA1m /wpyztwqlY5wRmG2eStEjvtA9BDnKmrDw5/58R4mtrQWhzt8kKX9UAmZtep/tY/HTu ac3UJhVBT+xaazV5aPKeLhLAKMsEdPyCDYzVVq3YOjqJCCwuIRW9VnczsfEFpYlWbJ XgBvyhim8T6dA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RFkGx49hdz6v1B; Tue, 1 Aug 2023 20:32:09 +0200 (CEST) In-Reply-To: (Jim Porter's message of "Tue, 1 Aug 2023 11:10:54 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266473 Archived-At: Jim Porter writes: > On 8/1/2023 10:29 AM, Mattias Engdeg=C3=A5rd wrote: >> An alternative would be to match against >> (mapconcat #'identity byte-compile-ignore-files "\\|") ...) > > Yeah, I thought about that too. I'm not sure if this would be better > than using 'seq-some' though; if anyone else has strong opinions on > this, I'm happy to change the code to whatever the preferred > implementation is. (I'm also not sure the specific implementation > matters too much since I doubt this bit is a performance bottleneck.) The mistake in my previous message was, that I was under the false assumption that regexp-opt did what Mattias mentioned above (I guess the reason is that I faintly remembered that the docstring of regexp-opt mentions (mapconcat 'regexp-quote strings "\\|"), and for some reason I belive the 'regexp-quote was an 'identity). In that case we should certainly apply a patch along the lines of what you suggested, but I would prefer the mapconcat approach, if anything because of the micro-optimisation of avoiding the overhead for the generic seq call and having the create and apply closure over and over again. Not sure if this counts as a strong preference, but it certainly is a preference.