From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Fri, 22 Sep 2023 13:38:53 +0000 Message-ID: <87a5tewcnm.fsf@localhost> References: <878r919qfh.fsf@localhost> <72c93fb0-bf3e-3dad-69c0-2147cfa40f57@gutov.dev> <875y42xyex.fsf@localhost> <87zg1ewfc2.fsf@localhost> <9d84725f-fd46-ab26-3b54-97cb4cf45e33@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2294"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66117@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 15:38:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjgMG-0000Oe-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 15:38:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjgLx-0007Bs-Rb; Fri, 22 Sep 2023 09:37:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjgLw-0007Bh-44 for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:37:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjgLv-0000qS-SJ for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:37:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjgM6-0000yr-2m for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.16953898793761 (code B ref 66117); Fri, 22 Sep 2023 13:38:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 22 Sep 2023 13:37:59 +0000 Original-Received: from localhost ([127.0.0.1]:35675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjgM2-0000ya-SP for submit@debbugs.gnu.org; Fri, 22 Sep 2023 09:37:59 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:33785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjgLy-0000yK-TN for 66117@debbugs.gnu.org; Fri, 22 Sep 2023 09:37:57 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 29F99240027 for <66117@debbugs.gnu.org>; Fri, 22 Sep 2023 15:37:38 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RsYH52rcsz9s1M; Fri, 22 Sep 2023 15:37:37 +0200 (CEST) In-Reply-To: <9d84725f-fd46-ab26-3b54-97cb4cf45e33@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271097 Archived-At: Dmitry Gutov writes: >> However, upon recording the profiler report with that change, >> `find-buffer-visiting' still took a significant fraction of CPU time. >> So, I decided to reach out upstream. > > Because the rest of the calls are made from Org? I am not 100% sure what you mean. > I see this in the profile, though: > > 6247 20% - editorconfig--advice-find-file-noselect > > There seems to be a lot of timers in that profile, and this is in one of > them (under "Automatic GC" which takes up 53% of the time). > > So one was to improve this in the meantime would be to bring it up with > "editorconfig" authors. I would even question the wisdom of advising > find-file-noselect. Nope. If you dig deeper, you will see that it is an around advice that later calls the original `find-file-noselect', where we spend most of the time: 6247 20% - editorconfig--advice-find-file-noselect 6247 20% - let 6247 20% - let 6247 20% - setq 6247 20% - apply 1773 5% - # 1773 5% - if 1773 5% - if 1773 5% - let* 1773 5% - and 1773 5% + find-buffer-visiting 1666 5% - # 1666 5% - if 1666 5% - if 1666 5% - let* 1666 5% - and 1666 5% + find-buffer-visiting 1006 3% - # 1006 3% - if 1006 3% - if 1006 3% - let* 1006 3% - if 1006 3% - setq 1006 3% + create-file-buffer 830 2% - # 830 2% - if 830 2% - if 830 2% - let* 830 2% - and 830 2% + find-buffer-visiting 776 2% - # 776 2% - if 776 2% - if 776 2% - let* 776 2% - and 776 2% + find-buffer-visiting -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at