From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Date: Wed, 04 Oct 2023 01:25:20 +0200 Message-ID: <87a5sz70gv.fsf@gmx.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17115"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66328@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 04 01:25:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnoly-0004Bj-H0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Oct 2023 01:25:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnolu-0000yQ-TD; Tue, 03 Oct 2023 19:25:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnolt-0000y2-C7 for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 19:25:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnolt-0002sr-3l for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 19:25:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnomA-0003zE-GN for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 19:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2023 23:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66328 X-GNU-PR-Package: emacs Original-Received: via spool by 66328-submit@debbugs.gnu.org id=B66328.169637555015307 (code B ref 66328); Tue, 03 Oct 2023 23:26:02 +0000 Original-Received: (at 66328) by debbugs.gnu.org; 3 Oct 2023 23:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:40902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnoly-0003yo-DD for submit@debbugs.gnu.org; Tue, 03 Oct 2023 19:25:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:49705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnolw-0003yb-A9 for 66328@debbugs.gnu.org; Tue, 03 Oct 2023 19:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1696375521; x=1696980321; i=stephen.berman@gmx.net; bh=JjTBpZixokUJw5TEmuLcoNHQJ7ECjsXeOiNArv/7IWE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=oHFq5hKcnMy6ocan/+pz1wYAZE4cDC0obRUHbR0sggyHhsKkIH2U+r5J6Dsnfyt7NprG7JvkhBZ UnUGQL6E8Sp28ZkXifBiXGUXQjYFubAIEucIo6/BXG1eMukWIwAj+MpSNILLq87WzblOmr3Ic2u0d Rsln2+Ehv43Z4TzOjpYZzjfTCBlCgQiqGkrSeIf+6mrNRNwiJ6u1653/2J80ZV/cx49iCljUVeWzC Gru6UwnQzkZ7s4qQaH/euUnaWMWNlnc5AKxxH9V9LubOyMDHPZNV87u4RtaLSXR64Rxw6QXuUbtnr iWY1qXlJkG7hAZg6asRW/JMbSmfnMVCvf/1A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs2 ([94.134.196.39]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N9MpY-1rhpcz2e1c-015Ej0; Wed, 04 Oct 2023 01:25:21 +0200 In-Reply-To: (Drew Adams's message of "Tue, 3 Oct 2023 22:11:41 +0000") X-Provags-ID: V03:K1:sfGqAP5/p3/hjO8AedR5HDMDwADogNQ+IQ+H43yEqTAQhIAw6v2 ycPvCIFu7v4Y7FAG6oKn0e6a29XKq3xxKwptkJIi/40OJJMJpPMGvsLOa98k/WG1o1ilj+z 27NsGkxxj27PZhtpvHL4UZ6RVVM2ZTHRFOFdH5x3OYPz1w/oMQKv2hzVo4ofbac6H1BcX3X U+oQSHNBfi/QOePZQ/LEA== UI-OutboundReport: notjunk:1;M01:P0:we0rEJkLFg8=;5Bs5PIbP8sIowwCEDe3U+0FdNKf I1ODKy0DUh/4aa9rDhg3vFIsFmYfUgonJ7cE677o/o01bTPye7oZ8XUIFSxoZTWGE/8C6OCxb U7fXC+sQlVIfQtBO9AQ8wbsicKjWTO7zNDiovY+HbWRPPnf2N811+MHooEqbZlBIehwRoT/qW 5WuWjhoMp4qBW1nYrAoqM9x3azf2tZapBj3w0seALQGG3y4OBLNCrIAt7iuRRZKDrdfS5PNZP 6fbuIe79jPXTFWIEk9dTAM8fkiqxssg2tPGXCcdbUjJxzoPmqX9WYe3OriLT+WC2YVJKsR2N7 YsEKiPtftH7jLSzXT675xAmsuQyvaK1V/0i3Up1UZz3BmhMljlBnoWUyMiyIX6K00TazhGACq nN2hg+plU8e8nNtAs5ehqHrer2nOUfSIjdVi3M5y/br8z+SxuubTBkt+MclQxE5/LnQ10TVFi POfm04KNgmAff8hDjjX2/LaDbfzmc2+Hg2hml/g8RQfwwaWbr+oiPDYtyJ3ZmcFq4jgyU4sWE 4p+DQ60IlQWYrh7zynv7NF44jsiegpbcgZpLcXhdlmV/XtXrwA+BaA8XH4VrqnN6f/gc8Ai2M 617B9yJIm/OzLjnCoBLqFAKiIilL7rzPVHrwlqXSJZDe08tI7gzoJJ+8iAnwzxzRC8YGIOAjU G7MaCKzd+pZkwVqa7m9MQ8M52qbbxFUfWXOoZRBNOf8O9IidwBmk689gBIrzcMH9FYDuwUUA3 +nusOoXpQfA2O/MNdbYPZdx15f1igDhqg/Iw/wm7w4YIW7NvywW29t8CXql16qE3gn9JOf0u X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271748 Archived-At: On Tue, 3 Oct 2023 22:11:41 +0000 Drew Adams wrote: > How did the signature of `completing-read' get changed? I didn't notice > any proposal or discussion about this in emacs-devel@gnu.org. Did I > just miss it somehow? > > It used to be that _any_ REQUIRE-MATCH value that is not `t', nil, > `confirm', or `confirm-after-completion' behaves like `t', except that > type RET doesn't exit if what you type does non-null completion. > > That's no longer true if the value is a function! This completely > changes the behavior of `completing-read'. > > Not happy with the result, and not happy with how the process - how this > was done, if it wasn't discussed openly in emacs-devel. There was a short discussion, after the change was made, starting here: https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00539.html Steve Berman