From: Stephen Berman <stephen.berman@gmx.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 66328@debbugs.gnu.org
Subject: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code
Date: Wed, 04 Oct 2023 01:25:20 +0200 [thread overview]
Message-ID: <87a5sz70gv.fsf@gmx.net> (raw)
In-Reply-To: <SJ0PR10MB548844B540AD934B8CAD5720F3C4A@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Tue, 3 Oct 2023 22:11:41 +0000")
On Tue, 3 Oct 2023 22:11:41 +0000 Drew Adams <drew.adams@oracle.com> wrote:
> How did the signature of `completing-read' get changed? I didn't notice
> any proposal or discussion about this in emacs-devel@gnu.org. Did I
> just miss it somehow?
>
> It used to be that _any_ REQUIRE-MATCH value that is not `t', nil,
> `confirm', or `confirm-after-completion' behaves like `t', except that
> type RET doesn't exit if what you type does non-null completion.
>
> That's no longer true if the value is a function! This completely
> changes the behavior of `completing-read'.
>
> Not happy with the result, and not happy with how the process - how this
> was done, if it wasn't discussed openly in emacs-devel.
There was a short discussion, after the change was made, starting here:
https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00539.html
Steve Berman
next prev parent reply other threads:[~2023-10-03 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 22:11 bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Drew Adams
2023-10-03 23:25 ` Stephen Berman [this message]
2023-10-04 2:04 ` Drew Adams
2023-10-04 7:31 ` Eli Zaretskii
2023-10-04 7:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5sz70gv.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=66328@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).