From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sat, 07 Oct 2023 08:25:06 +0000 Message-ID: <87a5su261p.fsf@localhost> References: <878r919qfh.fsf@localhost> <72c93fb0-bf3e-3dad-69c0-2147cfa40f57@gutov.dev> <875y42xyex.fsf@localhost> <87zg1ewfc2.fsf@localhost> <834jjm749q.fsf@gnu.org> <87cyyawd1a.fsf@localhost> <83pm2a5k85.fsf@gnu.org> <87wmwh2tae.fsf@localhost> <83zg1d468w.fsf@gnu.org> <87bkdr2651.fsf@localhost> <87pm2584oz.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4826"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 10:25:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qp2cd-0000zp-El for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 10:25:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qp2c8-0007w6-NO; Sat, 07 Oct 2023 04:24:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp2c7-0007vy-9q for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 04:24:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qp2c7-0005S6-1G for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 04:24:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qp2cQ-0005ea-1O for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 04:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 08:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.169666705221666 (code B ref 66117); Sat, 07 Oct 2023 08:25:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 7 Oct 2023 08:24:12 +0000 Original-Received: from localhost ([127.0.0.1]:53277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp2bc-0005dO-8r for submit@debbugs.gnu.org; Sat, 07 Oct 2023 04:24:12 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp2bY-0005d6-CQ for 66117@debbugs.gnu.org; Sat, 07 Oct 2023 04:24:09 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 82E66240103 for <66117@debbugs.gnu.org>; Sat, 7 Oct 2023 10:23:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1696667022; bh=BwFjRxXS3U388L8zY8ExlKiE0KPrWAO72oj5wd7B32g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=iZ3NPZ0r+SYPWmicHIhsAcIE11PC6jpzTf3GWj9iRlviTUFUQD9Nsdy6MpVrn/A1p RXONlDX0V0PkO/rxF08OV2Hooaao8LYbNXm8/9ue+MbGhIlaaJrQLaH7VEQcynMm6H 6pMppXhGR9bLCFWaB9FMiFlSYNrdhmlehzxcCBKxqllC6sc+E/yVmB4O2RrC7ganU5 s29RZwmcdCkTd/VH73KqvTVl4PTQ3Fm1EOp6BRfA4MEHK07RIrhtq0S0rtOEz3/xzN YEC3tRBZq+WI/7/WSYP+vxFHC4RED1uXUqgAbZ3yXG+JtGPwB6Pm5ZPsEvwKZsjkNm v+gxyGbix9qMQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S2dbx49VRz9rxD; Sat, 7 Oct 2023 10:23:41 +0200 (CEST) In-Reply-To: <83ttrdx8j9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271981 Archived-At: Eli Zaretskii writes: >> >> If one uses `get-file-buffer' instead of `find-buffer-visiting', the >> >> total runtime becomes 5.1 sec - almost 4x faster. >> > >> > This is also not very interesting, since find-file-noselect calls >> > get-file-buffer as well. >> >> No. `find-file-noselect' calls `find-buffer-visiting'. > > Unless we use different Emacsen, find-file-noselect calls both > get-file-buffer and find-buffer-visiting: > > (let* ((buf (get-file-buffer filename)) <<<<<<<<<<<<<<<<<<<<<<<<<<<< We are probably mis-communicating. My point is that `get-file-buffer' is very fast (for my purposes). So, it does not matter as much if it is called somewhere else and how many times. Although, as Dmitry demonstrated, `get-file-buffer' might be slow in certain scenarios. But let's postpone that discussion after we handle the much slower `find-buffer-visiting'. >> I still think that my previous conclusions are true. And I agree that >> rewriting these expensive loops in C makes sense. Maybe two new >> subroutines to find buffer by `buffer-file-truename' and by >> `buffer-file-number'? > > Yes, that's what I had in mind. I looked closer, and there is already `get_truename_buffer', which can simply be exposed to Lisp. `buffer-file-number' is a bit more tricky - it is not defined in C, but in files.el. However, I am wondering if this variable should be moved to C or maybe into the buffer object. `make-indirect-buffer' (defined in C) has Fset (intern ("buffer-save-without-query"), Qnil); Fset (intern ("buffer-file-number"), Qnil); WDYT? >> Aside: this reminds me about obsoletion of generalized buffer-local >> variable. AFAIU, there is currently no way to set buffer-local value in >> buffer without setting that buffer to current. It would be nice if such >> setting were possible, especially in performance-critical code. > > Maybe, but is there any performance-critical code which needs that? For example, org-element.el needs to set buffer-local values in base buffer of an indirect buffer every time buffer text is being edited. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at